Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scan] Half-image decoding is crashing on iOS #1581

Closed
g123k opened this issue Apr 15, 2022 · 5 comments
Closed

[Scan] Half-image decoding is crashing on iOS #1581

g123k opened this issue Apr 15, 2022 · 5 comments
Assignees
@g123k
Labels
🐛 bug Something isn't working camera crash 🍎 iOS iOS specific issues or PRs 🎯 P1
Milestone
V1.1

Comments

@g123k
Copy link
Collaborator

g123k commented Apr 15, 2022 •
edited by teolemon
Loading

What

Error Thread 6: EXC_BAD_ACCESS (code=1, address=0x1548c0000)

Trigerred by: pixelBufferToVisionImage method in MLKVisingImage

Part of
@g123k g123k added 🍎 iOS iOS specific issues or PRs camera crash labels Apr 15, 2022
@g123k g123k mentioned this issue Apr 15, 2022
Closed
@monsieurtanuki
Copy link
Contributor

My suggestion: just don't use it. It's experimental.
And we could not test if it improved performances anyway.
Putting the focus on (.5,.25) looks like a much better idea.

@g123k
Copy link
Collaborator Author

g123k commented Apr 15, 2022

Honestly, on Android the results are far better.
I've just fixed the crash on iOS. This value is still "experimental"

@monsieurtanuki
Copy link
Contributor

Honestly, on Android the results are far better.

Wonderful!

I've just fixed the crash on iOS. This value is still "experimental"

Good!

@teolemon teolemon added this to the V1 milestone Apr 15, 2022
@g123k g123k self-assigned this Apr 16, 2022
@teolemon teolemon added the 🐛 bug Something isn't working label Apr 22, 2022
@teolemon teolemon changed the title Half image decoding is crashing on iOS [Scan] Half-image decoding is crashing on iOS Apr 22, 2022
@teolemon teolemon mentioned this issue Apr 30, 2022
Closed
@g123k g123k modified the milestones: V1, V1.1 May 9, 2022
@g123k
Copy link
Collaborator Author

g123k commented May 18, 2022

This issue should be solved directly in https://github.com/openfoodfacts/google_ml_barcode_scanner

@teolemon
Copy link
Member

Ok, closing then @g123k

Repository owner moved this from In Progress to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g123k g123k

Labels
🐛 bug Something isn't working camera crash 🍎 iOS iOS specific issues or PRs 🎯 P1
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1.1
Development

Successfully merging a pull request may close this issue.

fix: Crash on iOS devices with half image cropping openfoodfacts/smooth-app
4 participants
@g123k @teolemon @monsieurtanuki @olivierdrouard