Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: LogoAnnotations - Label addition #38

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: LogoAnnotations - Label addition #38

wants to merge 8 commits into from

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented May 2, 2019 •
edited
Loading

What

  • Using Google Cloud Vision's annotation to create insights about common labels.
  • This is complementary to our Logos & Labels custom model, and will work only on the very popular things Cloud Vision is able to recognize.

Part of

@teolemon
Work in Progress
3b2ff38 
Work in Progress
@teolemon teolemon changed the title Work in Progress (Label addition from LogoAnnotations) Work in Progress May 6, 2019
@teolemon teolemon changed the title (Label addition from LogoAnnotations) Work in Progress [WIP] Label addition from LogoAnnotations May 9, 2019
@teolemon teolemon changed the title [WIP] Label addition from LogoAnnotations [WIP] LogoAnnotations - Label addition May 9, 2019
@teolemon teolemon requested a review from raphael0202 July 9, 2019 18:03
@raphael0202 raphael0202 marked this pull request as draft April 25, 2020 14:59
@raphael0202 raphael0202 force-pushed the master branch 2 times, most recently from 290fbc8 to 43cb71c Compare May 2, 2020 11:58
@raphael0202 raphael0202 force-pushed the master branch 5 times, most recently from 0c0dd17 to aacd463 Compare June 11, 2020 15:17
@teolemon teolemon requested a review from kulizhsy August 24, 2021 16:30
@teolemon teolemon changed the title [WIP] LogoAnnotations - Label addition LogoAnnotations - Label addition Aug 24, 2021
@teolemon teolemon marked this pull request as ready for review August 24, 2021 16:30
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 24, 2021 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@eaaff12). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage        ?   56.43%           
=======================================
  Files           ?       79           
  Lines           ?     7936           
  Branches        ?        0           
=======================================
  Hits            ?     4479           
  Misses          ?     3457           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kulizhsy
kulizhsy reviewed Aug 25, 2021
View reviewed changes
data/ocr/label_logo_annotation.txt Outdated
usda organic||en:USDA Organic
USDA Organic||en:USDA Organic
UTZ Certified||en:UTZ
UTZ||en:UTZ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these labels standartised in anyway? For example lines 92 and 93 assign en:UTZ, while line 107 assigns en:utz-certified for seemingly the same thing?

kulizhsy
kulizhsy reviewed Aug 25, 2021
View reviewed changes
data/ocr/label_logo_annotation.txt
Pensez Au Tri||fr:Pensez Au Tri
produit de montagne||fr:produit de montagne
produit en bretagne||en:produced-in-bretagne
Produit en Bretagne||en:produced-in-bretagne
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it should be possible to add some normalization here to lower case all input, remove punctuation etc. such that we don't need to explicitly list all of the possible variations of one label, like produit en bretagne vs. Produit en Bretagne?

@teolemon
Copy link
Member Author

teolemon commented Oct 3, 2022

It's not a fully new system, it's just incremental

@teolemon teolemon reopened this Oct 3, 2022
@teolemon teolemon marked this pull request as draft October 3, 2022 16:31
@teolemon teolemon marked this pull request as ready for review October 3, 2022 16:47
@teolemon teolemon requested a review from a team as a code owner October 3, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulizhsy kulizhsy kulizhsy left review comments

@raphael0202 raphael0202 Awaiting requested review from raphael0202

Assignees

@teolemon teolemon

Labels
category prediction Cloud Vision Crowdin 📚 Documentation elasticsearch GitHub Actions insights integration tests labels prediction neural category prediction object detection Predictions - OCR predictions robotoff app robotoff-cli scheduler 🏪 Stores 🧪 tests unit tests utils workers
Projects
🤖 Artificial Intelligence @ Open Food Facts
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teolemon @kulizhsy @raphael0202