-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use query service for obsolete queries #9228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
MongoDB
We have 2 mongodb collections: one for current products, and one for obsolete products
🧪 tests
JavaScript
GitHub Actions
Pull requests that update Github_actions code
Display
labels
Oct 30, 2023
stephanegigandet
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Co-authored-by: Stéphane Gigandet <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #9228 +/- ##
==========================================
+ Coverage 47.80% 47.88% +0.07%
==========================================
Files 65 65
Lines 20292 20266 -26
Branches 4932 4916 -16
==========================================
+ Hits 9701 9704 +3
+ Misses 9336 9307 -29
Partials 1255 1255
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Display
GitHub Actions
Pull requests that update Github_actions code
JavaScript
MongoDB
We have 2 mongodb collections: one for current products, and one for obsolete products
🗄 Obsolete products
🧪 tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The query parameters used in the PO query are passed through to the query service so that the obsolete flag can be set.
Also fixed an issue where the obsolete flag was not being taken into account for results caches.
Removed all references to the MongoDB products_tags collection
Related issue(s) and discussion