Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use query service for obsolete queries #9228

Merged
merged 6 commits into from
Oct 31, 2023
Merged

feat: Use query service for obsolete queries #9228

merged 6 commits into from
Oct 31, 2023

Conversation

john-gom
Copy link
Contributor

What

The query parameters used in the PO query are passed through to the query service so that the obsolete flag can be set.

Also fixed an issue where the obsolete flag was not being taken into account for results caches.

Removed all references to the MongoDB products_tags collection

Related issue(s) and discussion

@john-gom john-gom requested a review from a team as a code owner October 30, 2023 18:23
@github-actions github-actions bot added MongoDB We have 2 mongodb collections: one for current products, and one for obsolete products 🧪 tests JavaScript GitHub Actions Pull requests that update Github_actions code Display labels Oct 30, 2023
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Co-authored-by: Stéphane Gigandet <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Merging #9228 (759cab7) into main (67f09c1) will increase coverage by 0.07%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##             main    #9228      +/-   ##
==========================================
+ Coverage   47.80%   47.88%   +0.07%     
==========================================
  Files          65       65              
  Lines       20292    20266      -26     
  Branches     4932     4916      -16     
==========================================
+ Hits         9701     9704       +3     
+ Misses       9336     9307      -29     
  Partials     1255     1255              
Files Coverage Δ
lib/ProductOpener/Data.pm 76.62% <70.00%> (+0.62%) ⬆️
lib/ProductOpener/Display.pm 11.41% <37.50%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@john-gom john-gom merged commit 9018024 into main Oct 31, 2023
13 checks passed
@john-gom john-gom deleted the issues/9134 branch October 31, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Display GitHub Actions Pull requests that update Github_actions code JavaScript MongoDB We have 2 mongodb collections: one for current products, and one for obsolete products 🗄 Obsolete products 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Querying obsolete products through openfoodfacts-query
4 participants