Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Optimise Settings screen for dynamic type (#908) #910

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

bigimot22
Copy link
Contributor

PR Description

I have added better support for large dynamic types in the settings screens so the cells expand to accommodate larger font sizes and still look good.

This is my first open source pr, please review carefully 🤓

Proposed changes

  • Give cells an estimated row height of 200
  • Assure constraints to edges
  • Set labels to adjust font for content size category changes

Screenshots

Before

After

Checklist

Make sure you've done all the following (Put an x in the boxes that apply.)

  • [ x] If you have multiple commits please combine them into one commit by squashing them.
  • Code is well documented
  • Included unit tests for new functionality
  • All user-visible strings are made translatable
  • [ x] Code passes Travis builds in your branch

@teolemon teolemon requested a review from a team July 31, 2021 09:11
@teolemon teolemon requested a review from aleene August 1, 2021 17:28
@bigimot22
Copy link
Contributor Author

Hi, how is it going with the review? Any change require from my part? Im happy to help ✌️

@teolemon teolemon requested review from roger-tan and removed request for aleene August 17, 2021 09:51
@teolemon
Copy link
Member

@roger-tan does that look good to you ?

@teolemon
Copy link
Member

I'm going to go ahead and merge @bigimot22 👍

@teolemon teolemon merged commit 8d60492 into openfoodfacts:develop Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants