feat: 831 - latest "prices" API changes #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted files: * `get_prices_results.dart` * `validation_error.dart` * `validation_error.g.dart` * `validation_errors.dart` * `validation_errors.g.dart` New files: * `get_locations_order.dart`: Field for the "order by" clause of "get locations". * `get_locations_parameters.dart`: Parameters for the "get locations" API query. * `get_locations_result.dart`: List of location objects returned by the "get locations" method. * `get_locations_result.g.dart`: generated * `order_by.dart`: "Order by" clause for "get list" methods (e.g. "get prices") Impacted files: * `api_prices_test.dart`: impacted by `MaybeError` refactoring; tests for new methods `getOSMLocation`, `getLocations`, `getPriceProductByCode` * `get_prices_order.dart`: refactored using new class `OrderByField` * `get_prices_parameters.dart`: refactored using new class `OrderBy` * `open_prices_api_client.dart`: refactored using more systematically `MaybeError`; renamed `getPriceProduct` as `getPriceProductById`; added methods `getOSMLocation`, `getLocations`, `getPriceProductByCode` * `openfoodfacts.dart`: added the new files; removed the deleted files
teolemon
approved these changes
Apr 1, 2024
Thank you @teolemon for your approval! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
getOSMLocation,getLocations,getPriceProductByCode.Part of
Files
Deleted files:
get_prices_results.dartvalidation_error.dartvalidation_error.g.dartvalidation_errors.dartvalidation_errors.g.dartNew files:
get_locations_order.dart: Field for the "order by" clause of "get locations".get_locations_parameters.dart: Parameters for the "get locations" API query.get_locations_result.dart: List of location objects returned by the "get locations" method.get_locations_result.g.dart: generatedorder_by.dart: "Order by" clause for "get list" methods (e.g. "get prices")Impacted files:
api_prices_test.dart: impacted byMaybeErrorrefactoring; tests for new methodsgetOSMLocation,getLocations,getPriceProductByCodeget_prices_order.dart: refactored using new classOrderByFieldget_prices_parameters.dart: refactored using new classOrderByopen_prices_api_client.dart: refactored using more systematicallyMaybeError; renamedgetPriceProductasgetPriceProductById; added methodsgetOSMLocation,getLocations,getPriceProductByCodeopenfoodfacts.dart: added the new files; removed the deleted files