Support pannerAttr for Howler sounds + improve performance #1788
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the
pannerAttr
field, which allows panner values to be set. By setting thepanningModel
to"equalpower"
, which results in crisp sound within Howler, resolving the problem mentioned in goldfire/howler.js#112.The processing performance of
"equalpower"
is notable compared to HRTF: https://padenot.github.io/web-audio-perf/#pannernode-when-panningmodel--hrtfIn the future, panner attributes can be passed within the HTML5AudioSource
play()
function, or anywhere after the sound is active. It could also make sense to set a global pannerAttr that is referenced within theinit()
function.