Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow global in helm values to allow openfga as dependency chart #118

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

juusujanar
Copy link
Contributor

Allow global property in values schema to be able to use the chart as dependency chart.

Description

This PR adds a global property to openfga Helm chart values schema file. This allows using the Helm chart as a dependency chart and provide values to it.

References

Fixes #106

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@juusujanar juusujanar requested a review from a team as a code owner March 18, 2024 19:38
Copy link

linux-foundation-easycla bot commented Mar 18, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: juusujanar / name: Janar Juusu (a0aad26)
  • ✅ login: jon-whit / name: Jonathan Whitaker (7bb22f7)

@juusujanar juusujanar requested a review from a team as a code owner March 28, 2024 18:56
@jon-whit jon-whit enabled auto-merge (squash) March 28, 2024 18:56
@jon-whit jon-whit merged commit abff659 into openfga:main Mar 28, 2024
2 checks passed
@juusujanar juusujanar deleted the GlobalHelmValue branch April 2, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in helm template when openfga is used as dependency and has global property in values
3 participants