Fix undefined variable in python3-http-debian template #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions useing the http-debian tamplate where failing. The format_response function used an undefined variable 'resp' this should be 'res'. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The format_response function uses an undefined variable
respthis should beres. This bug causes functions using the http-debian template to fail.Motivation and Context
design/approvedlabelFunctions using the latest version of the
http-debiantemplate would fail with a status 500 this resolves that issueHow Has This Been Tested?
Verified deploying a function build using the updated template returns a 200 status code when invoked.
Types of changes
Checklist:
git commit -s