Use function name as cache key for function access tokens #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
Remove the source token from the cache key. By using the source token as part of the cache key the cache would be invalidated when the original access token had expired which is confusing for users and leads to higher load on the token exchange endpoint if short lived tokens are used. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the source token as part of the cache key.
By using the source token as part of the cache key the cache would be invalidated when the original access token had expired which is confusing for users and leads to higher load on the token exchange endpoint if short lived tokens are used.
Using the source token as part if the cache key is not required since an authenticated clients should not be shared between different users.
Motivation and context
Simplify the client and reduce the number of token exchanges required when using short lived tokens.
How has this been tested
This has been tested E2E in multiple OpenFaaS components (CLI, pro-connector-sdk)