-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples for all go sdk operations #27
Conversation
Signed-off-by: Nitishkumar Singh <[email protected]>
Hi @nitishkumar71 .. I'm wondering how people can run these examples? And how can we maintain them over time? Can you add a README file? Perhaps we can take inspiration from github-go, and create a folder for each example with a main.go? |
Sounds good to me. I will do it. |
Signed-off-by: Nitishkumar Singh <[email protected]>
I like the new structure, just a suggestion:
vs
This ran further code when I didn't have a valid gateway, instead of exiting. and fmt vs log |
Signed-off-by: Nitishkumar Singh <[email protected]>
173adc3
to
22b5617
Compare
feedback changes are done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Description
Add examples for all go sdk operations
Motivation and Context
Closes Add examples for all supported functionalities #26
How Has This Been Tested?
All examples have been copied from the previous PRs test cases.
Types of changes
Checklist:
Commits:
git commit -s
for the Developer Certificate of Origin (DCO)Code:
Docs: