Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor label parsing to set OF labels last #229

Closed
wants to merge 5 commits into from
Closed

Refactor label parsing to set OF labels last #229

wants to merge 5 commits into from

Commits on Oct 7, 2018

  1. Refactor label parsing to set OF labels last 

    **What**
- Ensure that internal OF labels are set after user labels to ensure
that users do no override these internal values
- Refactor the getMinReplicaCount to work with the labels pointer, this
helps simplify the control flow in the handler methods
- Add constants for the label keys and update all references to those
keys throughout

Closes openfaas#209

Signed-off-by: Lucas Roesler <[email protected]>
    @LucasRoesler
    LucasRoesler committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    310b5ec View commit details
    Browse the repository at this point in the history

  2. Update label constants to remove OF prefix 

    Signed-off-by: Lucas Roesler <[email protected]>
    @LucasRoesler
    LucasRoesler committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    5344c15 View commit details
    Browse the repository at this point in the history

  3. Move the uid into teh common label method 

    **What**
- moves the uid label into a constant
- sets it inside the labels method so that it is applied consistently

Signed-off-by: Lucas Roesler <[email protected]>
    @LucasRoesler
    LucasRoesler committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    8d22ce8 View commit details
    Browse the repository at this point in the history

  4. Rename parseLabels to buildLabels 

    **What**
- rename parseLabels to buildLables to make the name more semantic

Signed-off-by: Lucas Roesler <[email protected]>
    @LucasRoesler
    LucasRoesler committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    3413f25 View commit details
    Browse the repository at this point in the history

  5. Propagate getMinReplicaCount error to the handler 

    **What**
- Return parsing errors from getMinReplicaCount
- Add tests for the expected errors

Signed-off-by: Lucas Roesler <[email protected]>
    @LucasRoesler
    LucasRoesler committed Oct 7, 2018
    Configuration menu
    Copy the full SHA
    6edf7e3 View commit details
    Browse the repository at this point in the history