EWPP-164: Remove duplicated processing code to style a Media entity using the ECL media container #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drishu
force-pushed
the
EWPP-164B
branch
4 times, most recently
from
9bcf38d to
a0ca1e4
Compare
22Alexandra
previously approved these changes
Jan 19, 2021
georgebaev
previously approved these changes
Jan 22, 2021
22Alexandra
approved these changes
Jan 26, 2021
georgebaev
approved these changes
Jan 26, 2021
ademarco
requested changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EWPP-164
Description
Create a Media value object and a media container pattern to use it on oe_theme_preprocess_paragraph__oe_text_feature_media and featured media field formatter
Change log