-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sidebar to page template #308
base: 2.x
Are you sure you want to change the base?
Conversation
Tagged with ecl2 because the target is 2.x |
@@ -33,7 +35,12 @@ | |||
<section class="main-content ecl-u-mv-l"> | |||
<div class="ecl-container"> | |||
<div class="ecl-row"> | |||
<div class="ecl-col"> | |||
{% if page.sidebar %} | |||
<div class="ecl-col-12 ecl-col-lg-3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://ec.europa.eu/component-library/ec/templates/pages/search/code/ this div should be an aside
and we should change the main by a section
.
I would not add a sidebar in the main theme. Still this is a good occasion to improve our theme to be more extensible by sub-themes (which, I guess, you are using @haringsrob). In order to do that we could maybe rework this PR using Twig blocks on the page template, so that you could simply override a If you are ok with this approach please consider updating the documentation too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above.
Can be done by adding a
And adding the region to the
I still feel that on top of this theme a subset of functions can be provided to site builders that allow easier configuration of these sort of pages. |
provides a left sidebar as per the markup here: https://ec.europa.eu/component-library/playground/ec/?path=/story/templates-pages--search