Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove the redundant staleness waiting in test case testDateVal… #4942

Merged

Conversation

PenghaiZhang
Copy link
Contributor

Checklist
Description of change

CALBookActivationTest has been failing quite frequently due to an redundant wait of staleness. So I removed that wait and tested locally. Now let's see whether GHA will be happy with that.

@PenghaiZhang
Copy link
Contributor Author

First time all good. Now try second time.

@edalex-yinzi
Copy link
Contributor

Second time all good. Now try third time.

@edalex-yinzi
Copy link
Contributor

testEditNavigation faield

@edalex-yinzi
Copy link
Contributor

Fixed. Try fourth time.

@PenghaiZhang
Copy link
Contributor Author

Fixed. Try fourth time.

Thanks Yinzi! Looks like the CAL test is stable now.

Copy link
Member

@edalex-ian edalex-ian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty happy! GTG!

@PenghaiZhang PenghaiZhang marked this pull request as ready for review October 30, 2023 04:57
@PenghaiZhang PenghaiZhang merged commit 4f88400 into openequella:develop Oct 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants