-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds word cloud xblock extracting from edx-platform repo #4
base: main
Are you sure you want to change the base?
Conversation
200a788
to
91432f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple nits so far, but generally this is looking great. I still need to test it myself, but it's exciting to hear that you have this working in edx-platform 🔥
I'm going to hold off on testing this for now. Let's focus on getting all the stub XBlocks into #2, getting that reviewed and merged, and then getting the waffle flags into edx-platform. That way, it will be easy to test this PR in edx-platform. |
5ed4627
to
3c289df
Compare
b5b6bf9
to
24544fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase this Farhan? Then I'll be happy to test this using new flag we've added to edx-platform.
@kdmccormick This PR's branch is already up-to-date with the
Please suggest if we have better ways to do |
@farhan to test locally with tutor, you can mount the repo and rebuild+reboot:
With that setup, you should be able to |
Adds word cloud xblock extracting from edx-platform repo
Test PR
Deprecation/Test PR to install this xblock into
edx-patform
You also need to update entry_point in
Open_edX.egg-info/entry_points.txt
from
word_cloud
toword_cloud_deprecated
to make it work on local setupFile references:
xblocks_contrib/word_cloud/word_cloud.py
has been extracted fromxblocks_contrib/word_cloud/static/html/word_cloud_xblock.html
has been extracted fromxblocks_contrib/word_cloud/static/js/src/word_cloud_xblock.js
and otherd3-cloud files
has been extracted fromxblocks_contrib/word_cloud/static/css/word_cloud_xblock.css
has been extracted fromlms/static/css/WordCloudBlockDisplay.css
Pending
Managing global CSS Variables in pending:
i18n is pending, docs links:
https://edx.readthedocs.io/projects/xblock/en/latest/xblock-tutorial/edx_platform/edx_lms.html#internationalization-support
https://github.com/openedx/i18n-tools
https://github.com/openedx/staff_graded-xblock?tab=readme-ov-file
Acceptance Criteria:
All test cases listed in the description of this test PR should pass.(It's not required as above point is more suitable.)