Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skill validation exemption #195

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

muhammad-ammar
Copy link
Contributor

Description: Add skill validation exemption model and related functionality.

JIRA: https://2u-internal.atlassian.net/browse/ENT-8457

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • make upgrade && make requirements have been run to regenerate requirements
  • ./manage.py makemigrations has been run
    • Checkout the Database Migration Confluence page for helpful tips on creating migrations.
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.
  • Version bumped
  • Changelog record added

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub Actions, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in course-discovery to upgrade dependencies (including taxonomy-connector)
    • This must be done after the version is visible in PyPi as make upgrade in course-discovery will look for the latest version in PyPi.

taxonomy/api/v1/views.py Outdated Show resolved Hide resolved
@muhammad-ammar muhammad-ammar force-pushed the ammar/skill-validation-exemption branch from 50cc856 to d263031 Compare March 26, 2024 20:16
@muhammad-ammar muhammad-ammar force-pushed the ammar/skill-validation-exemption branch from d263031 to 3a31c52 Compare March 26, 2024 20:24
@muhammad-ammar muhammad-ammar marked this pull request as ready for review March 27, 2024 06:01
@muhammad-ammar muhammad-ammar force-pushed the ammar/skill-validation-exemption branch 5 times, most recently from 9560e08 to 66802a9 Compare March 27, 2024 06:52
@muhammad-ammar muhammad-ammar force-pushed the ammar/skill-validation-exemption branch from 66802a9 to e9f9c40 Compare March 27, 2024 07:00
@muhammad-ammar muhammad-ammar merged commit 46044fa into master Mar 27, 2024
8 of 10 checks passed
@muhammad-ammar muhammad-ammar deleted the ammar/skill-validation-exemption branch March 27, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants