Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scales down card logo cap #3218

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

brobro10000
Copy link
Member

@brobro10000 brobro10000 commented Sep 6, 2024

Description

Scales down the logo cap for card images for instances where a logo cap's aspect ratio is different then the default aspect ratio of the container.

Use cases for this change are GetSmarter course card image caps.
Example
Before:
Screenshot 2024-09-06 at 11 12 19 AM

After:
Screenshot 2024-09-06 at 11 13 24 AM

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit 42f48d8
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/66db1ba6a3517d00082ff5bb
😎 Deploy Preview https://deploy-preview-3218--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.25%. Comparing base (7988ffb) to head (42f48d8).
Report is 87 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3218   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files         249      249           
  Lines        4388     4388           
  Branches     1001     1035   +34     
=======================================
  Hits         4092     4092           
+ Misses        293      290    -3     
- Partials        3        6    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril brian-smith-tcril merged commit e7160b2 into master Sep 11, 2024
10 checks passed
@brian-smith-tcril brian-smith-tcril deleted the hu/ent-image-logo-cap branch September 11, 2024 15:37
@openedx-semantic-release-bot

🎉 This PR is included in version 22.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 23.0.0-alpha.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants