-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: scales down card logo cap #3218
Conversation
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3218 +/- ##
=======================================
Coverage 93.25% 93.25%
=======================================
Files 249 249
Lines 4388 4388
Branches 1001 1035 +34
=======================================
Hits 4092 4092
+ Misses 293 290 -3
- Partials 3 6 +3 ☔ View full report in Codecov by Sentry. |
🎉 This PR is included in version 22.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.0.0-alpha.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Scales down the logo cap for card images for instances where a logo cap's aspect ratio is different then the default aspect ratio of the container.
Use cases for this change are GetSmarter course card image caps.
Example
Before:
After:
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?Post-merge Checklist