Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] docs: added links to props API for components from Bootstrap #2945

Merged

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Dec 18, 2023

Description

  • added links to props API for components from Bootstrap
  • some refactoring

Issue: #2876

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 18, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft December 18, 2023 12:53
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 18, 2023

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 24a9d40
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/658568c67ecaf10008db8573
😎 Deploy Preview https://deploy-preview-2945--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/original-bootstrap-urls branch from f5d9fc4 to b7d84a7 Compare December 19, 2023 12:56
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40aea5e) 92.83% compared to head (135769c) 92.87%.
Report is 15 commits behind head on master.

❗ Current head 135769c differs from pull request most recent head 24a9d40. Consider uploading reports for the commit 24a9d40 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2945      +/-   ##
==========================================
+ Coverage   92.83%   92.87%   +0.03%     
==========================================
  Files         235      235              
  Lines        4245     4268      +23     
  Branches     1032     1033       +1     
==========================================
+ Hits         3941     3964      +23     
  Misses        300      300              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/original-bootstrap-urls branch from b37f7db to a7ae328 Compare December 19, 2023 13:42
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/original-bootstrap-urls branch from a7ae328 to 4e63c8b Compare December 19, 2023 14:15
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title docs: added original bootstrap urls [BD-46] docs: added links to props API for components from Bootstrap Dec 19, 2023
@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program and removed open-source-contribution PR author is not from Axim or 2U labels Dec 19, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review December 19, 2023 14:35
src/Icon/index.jsx Outdated Show resolved Hide resolved
www/src/components/PropsTable.tsx Outdated Show resolved Hide resolved
www/src/components/PropsTable.tsx Outdated Show resolved Hide resolved
@viktorrusakov viktorrusakov merged commit 1e58c10 into openedx:master Dec 22, 2023
8 checks passed
@openedx-semantic-release-bot

🎉 This PR is included in version 21.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 22.0.0-alpha.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[docs site] Explicitly specify links in the Props Table for passthrough/overridden components
4 participants