Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BD-46] refactor: segment events refactoring #2840

Merged
merged 8 commits into from
Dec 22, 2023
Merged

[BD-46] refactor: segment events refactoring #2840

merged 8 commits into from
Dec 22, 2023

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Nov 22, 2023 •
edited
Loading

Description

  • segment events refactoring.

Issue: #2622

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

openedx-webhooks commented Nov 22, 2023 •
edited
Loading

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft November 22, 2023 14:47
@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Nov 22, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 22, 2023 •
edited
Loading

✅ Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b1fa374
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/65841d8e5b0121000822efe3
😎 Deploy Preview https://deploy-preview-2840--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this pull request Nov 22, 2023
Closed
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/segment-refactoring branch from 04d0233 to 2d5d06a Compare November 23, 2023 11:07
@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c659cbf) 92.83% compared to head (b1fa374) 92.87%.
Report is 57 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2840      +/-   ##
==========================================
+ Coverage   92.83%   92.87%   +0.04%     
==========================================
  Files         235      235              
  Lines        4240     4268      +28     
  Branches     1029     1033       +4     
==========================================
+ Hits         3936     3964      +28     
  Misses        300      300              
  Partials        4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/segment-refactoring branch from 03d8133 to 9210ec6 Compare November 23, 2023 12:53
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review November 23, 2023 12:54
@PKulkoRaccoonGang
Copy link
Contributor Author

Once these changes are merged, the documentation will be updated.

viktorrusakov
viktorrusakov reviewed Dec 6, 2023
View reviewed changes
www/segment-events/index.js Outdated Show resolved Hide resolved
www/src/components/CodeBlock.tsx Outdated Show resolved Hide resolved
@PKulkoRaccoonGang
Copy link
Contributor Author

Updated documentation for segment elements

@PKulkoRaccoonGang
Copy link
Contributor Author

@viktorrusakov added a constant for the component generator. Please take a look.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/segment-refactoring branch from e809a3a to b1fa374 Compare December 21, 2023 11:12
@viktorrusakov viktorrusakov merged commit e3a34e1 into openedx:master Dec 22, 2023
10 checks passed
@viktorrusakov viktorrusakov linked an issue Dec 22, 2023 that may be closed by this pull request
[BD-46] Segment event refactoring #2622
Closed
@openedx-semantic-release-bot
Copy link

🎉 This PR is included in version 21.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot
Copy link

🎉 This PR is included in version 22.0.0-alpha.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

khudym pushed a commit to khudym/paragon that referenced this pull request Jan 2, 2024
@PKulkoRaccoonGang
refactor: colocate segment events (openedx#2840)
8e61143 
* refactor: segment events refactoring

* refactor: alternative refactoring variant for event segments

* refactor: some refactoring

* refactor: refactoring after review

* refactor: refactoring after review

* refactor: refactoring after review

* refactor: corrected settings changed event

* refactor: added segment constant for component generator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktorrusakov viktorrusakov viktorrusakov approved these changes

@adamstankiewicz adamstankiewicz Awaiting requested review from adamstankiewicz

@monteri monteri Awaiting requested review from monteri

Assignees
No one assigned
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
2U Blended Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BD-46] Segment event refactoring
5 participants
@PKulkoRaccoonGang @openedx-webhooks @openedx-semantic-release-bot @monteri @viktorrusakov