-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] feat: added Segment track for CLI scripts #2617
Merged
viktorrusakov
merged 5 commits into
openedx:alpha
from
raccoongang:Peter_Kulko/segment-track-for-cli-scripts
Nov 9, 2023
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
222ab8d
feat: added Segment track for CLI scripts
PKulkoRaccoonGang cb9dcb8
refactor: refactoring after review
PKulkoRaccoonGang e6ccd35
refactor: refactoring after review
PKulkoRaccoonGang 9787ccb
refactor: refactoring after review
PKulkoRaccoonGang cae891e
refactor: code refactoring
PKulkoRaccoonGang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
const axios = require('axios'); | ||
|
||
/** | ||
* Sends request to the Netlify function to inform about specified event. | ||
* @param {string} eventId - tracking event id | ||
* @param {object} properties - tracking properties | ||
*/ | ||
function sendTrackInfo(eventId, properties) { | ||
const { BASE_URL, TRACK_ANONYMOUS_ANALYTICS } = process.env; | ||
if (TRACK_ANONYMOUS_ANALYTICS) { | ||
const url = `${BASE_URL}/.netlify/functions/sendTrackData`; | ||
axios.post(url, { eventId, properties }) | ||
.then(result => { | ||
// eslint-disable-next-line no-console | ||
console.log(`Track info is successfully sent (status ${result.status})`); | ||
}).catch(error => { | ||
// eslint-disable-next-line no-console | ||
console.log(`Track info request failed (${error})`); | ||
}); | ||
} | ||
} | ||
|
||
module.exports = { sendTrackInfo }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
const { v4: uuidv4 } = require('uuid'); | ||
const Analytics = require('analytics-node'); | ||
|
||
const analytics = new Analytics(process.env.SEGMENT_KEY); | ||
|
||
exports.handler = async function eventHandler(event) { | ||
// Only allow POST | ||
if (event.httpMethod !== 'POST') { | ||
return { statusCode: 405, body: 'Method Not Allowed' }; | ||
} | ||
const { eventId, properties } = JSON.parse(event.body); | ||
// dispatch event to Segment | ||
analytics.track({ | ||
anonymousId: uuidv4(), | ||
event: eventId, | ||
properties, | ||
}); | ||
|
||
return { | ||
statusCode: 200, | ||
body: JSON.stringify({ success: true }), | ||
}; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,12 @@ | ||
const { v4: uuidv4 } = require('uuid'); | ||
const Analytics = require('analytics-node'); | ||
|
||
const analytics = new Analytics(process.env.SEGMENT_KEY); | ||
const { handler: actualHandler } = require('./sendAnalyticsData'); | ||
|
||
exports.handler = async function eventHandler(event) { | ||
// Only allow POST | ||
if (event.httpMethod !== 'POST') { | ||
return { statusCode: 405, body: 'Method Not Allowed' }; | ||
} | ||
const { componentName } = JSON.parse(event.body); | ||
// dispatch event to Segment | ||
analytics.track({ | ||
anonymousId: uuidv4(), | ||
event: 'openedx.paragon.functions.track-generate-component.created', | ||
properties: { componentName }, | ||
const body = JSON.parse(event.body); | ||
event.body = JSON.stringify({ | ||
...body, | ||
eventId: 'openedx.paragon.functions.track-generate-component.created', | ||
properties: { componentName: body.componentName }, | ||
}); | ||
|
||
return { | ||
statusCode: 200, | ||
body: JSON.stringify({ success: true }), | ||
}; | ||
return actualHandler(event); | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we use
paragon CLI
in productionaxios
it is required to have independencies
instead ofdevDependencies
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done