fix(Table): add aria-hidden to sort icons in Table (#76)

add aria-hidden tag to the table headings of sortable columns in a sortable Table so icons are not read aloud to screen-reader users
openedx · Nov 20, 2017 · c9e0581 · c9e0581
1 parent 4f39d7b
commit c9e0581
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/.storybook/__snapshots__/Storyshots.test.js.snap b/.storybook/__snapshots__/Storyshots.test.js.snap
@@ -1602,6 +1602,7 @@ exports[`Storyshots Table sortable 1`] = `
             </span>
              
             <span
+              aria-hidden={true}
               className="fa fa-sort-desc"
             />
           </span>

diff --git a/src/Table/index.jsx b/src/Table/index.jsx
@@ -59,6 +59,7 @@ class Table extends React.Component {
 
     return (<span
       className={classNames(FontAwesomeStyles.fa, FontAwesomeStyles[sortIconClassName])}
+      aria-hidden
     />);
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -1602,6 +1602,7 @@ exports[`Storyshots Table sortable 1`] = ` @@
                 </span>
                 <span
+                  aria-hidden={true}
                   className="fa fa-sort-desc"
                 />
               </span>
@@ Expand Down @@