Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make object_id field case insensitive #86

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Sep 26, 2023

Description

Make object_id case-sensitive

Supporting Information

Testing instructions

  • Please ensure that the tests cover the expected behavior of the view as described in the related issue.

After merge

  • Create a Tag with the version v0.1.8

Private-ref: FAL-3508

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 26, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 26, 2023

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@rpenido rpenido force-pushed the rpenido/fal-3508-make-tagged-component-ids-case-sensitive branch from cc84137 to 13009c2 Compare September 26, 2023 14:44
@rpenido rpenido force-pushed the rpenido/fal-3508-make-tagged-component-ids-case-sensitive branch from 44c1660 to 9f0af8c Compare September 26, 2023 15:02
@rpenido rpenido marked this pull request as ready for review September 26, 2023 17:35
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido Looks good to me 👍

  • I tested this: I read through the tests to make sure it covers the cases. I ran te migrations and test.
  • I read through the code

@bradenmacdonald bradenmacdonald merged commit 0c4ca76 into openedx:main Sep 28, 2023
6 checks passed
@openedx-webhooks
Copy link

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald bradenmacdonald deleted the rpenido/fal-3508-make-tagged-component-ids-case-sensitive branch September 28, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tagging] Make ObjectTag.object_id case-sensitive
4 participants