Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add enterprise signal for learner credit fulfillment revokation #380

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

pwnage101
Copy link
Contributor

ENT-9213

@pwnage101 pwnage101 requested a review from a team as a code owner July 30, 2024 22:35
@pwnage101 pwnage101 force-pushed the pwnage101/ENT-9213 branch 6 times, most recently from 8629366 to b9d781c Compare July 31, 2024 18:02
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with a couple docs-related nits and a sanity check type question.

openedx_events/enterprise/data.py Outdated Show resolved Hide resolved
openedx_events/enterprise/data.py Outdated Show resolved Hide resolved
openedx_events/enterprise/data.py Show resolved Hide resolved
@pwnage101 pwnage101 force-pushed the pwnage101/ENT-9213 branch from b9d781c to c13054e Compare July 31, 2024 19:02
@pwnage101
Copy link
Contributor Author

@mariajgrimaldi please take a look when you have a chance!

@iloveagent57
Copy link
Contributor

@pwnage101 it'll probably be useful for Maria or others in the community to paste in some context from ENT-9213 (which they won't be able to access). Also maybe add links to the edx-enterprise models that this new signal-data correspond to.

@pwnage101
Copy link
Contributor Author

Fair, so first here's the ticket body for ENT-9213:

Background

There is an enterprise-subsidy cron job that writes reversals from recently unenrolled records to get transactions into a reversed state (at which point we'll send an event that causes the corresponding assignment to be reversed). We should eliminate that cron/mgmt command and replace it with an event producer/consumer.

AC

  • Add a new event for enterprise unenrollment events LearnerCreditEnterpriseCourseEnrollment
  • enterprise-subsidy consumes these events in real time and writes reversal for that one learner.
    • Ensure that enterprise-subsidy has appropriate roles, ACLs, API keys etc. to be a consumer of openedx events.

@mariajgrimaldi
Copy link
Member

Hi folks! Thank you for your contribution. I'll be reviewing this as soon as I can. Thanks for the patience!

@pwnage101
Copy link
Contributor Author

FYI, I also updated the docstrings with direct links to django models in openedx code.

Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few non-blocking comments. Thanks for the patience!

openedx_events/enterprise/data.py Show resolved Hide resolved
openedx_events/enterprise/data.py Show resolved Hide resolved
@pwnage101
Copy link
Contributor Author

@mariajgrimaldi please merge at your earliest convenience, as I do not have write access to this repository.

@mariajgrimaldi mariajgrimaldi merged commit 0e47ee1 into openedx:main Aug 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants