-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add courseaccessrole events #309
Merged
mariajgrimaldi
merged 1 commit into
openedx:main
from
zacharis278:zhancock/course-access-role-events
Feb 1, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,4 @@ | |
| more information about the project. | ||
| """ | ||
|
|
||
| __version__ = "9.3.0" | ||
| __version__ = "9.4.0" | ||
67 changes: 67 additions & 0 deletions
67
..._bus/avro/tests/schemas/org+openedx+learning+user+course_access_role+added+v1_schema.avsc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| { | ||
| "name": "CloudEvent", | ||
| "type": "record", | ||
| "doc": "Avro Event Format for CloudEvents created with openedx_events/schema", | ||
| "fields": [ | ||
| { | ||
| "name": "course_access_role_data", | ||
| "type": { | ||
| "name": "CourseAccessRoleData", | ||
| "type": "record", | ||
| "fields": [ | ||
| { | ||
| "name": "user", | ||
| "type": { | ||
| "name": "UserData", | ||
| "type": "record", | ||
| "fields": [ | ||
| { | ||
| "name": "id", | ||
| "type": "long" | ||
| }, | ||
| { | ||
| "name": "is_active", | ||
| "type": "boolean" | ||
| }, | ||
| { | ||
| "name": "pii", | ||
| "type": { | ||
| "name": "UserPersonalData", | ||
| "type": "record", | ||
| "fields": [ | ||
| { | ||
| "name": "username", | ||
| "type": "string" | ||
| }, | ||
| { | ||
| "name": "email", | ||
| "type": "string" | ||
| }, | ||
| { | ||
| "name": "name", | ||
| "type": "string" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "name": "org_key", | ||
| "type": "string" | ||
| }, | ||
| { | ||
| "name": "course_key", | ||
| "type": "string" | ||
| }, | ||
| { | ||
| "name": "role", | ||
| "type": "string" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ], | ||
| "namespace": "org.openedx.learning.user.course_access_role.added.v1" | ||
| } |
67 changes: 67 additions & 0 deletions
67
...us/avro/tests/schemas/org+openedx+learning+user+course_access_role+removed+v1_schema.avsc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| { | ||
| "name": "CloudEvent", | ||
| "type": "record", | ||
| "doc": "Avro Event Format for CloudEvents created with openedx_events/schema", | ||
| "fields": [ | ||
| { | ||
| "name": "course_access_role_data", | ||
| "type": { | ||
| "name": "CourseAccessRoleData", | ||
| "type": "record", | ||
| "fields": [ | ||
| { | ||
| "name": "user", | ||
| "type": { | ||
| "name": "UserData", | ||
| "type": "record", | ||
| "fields": [ | ||
| { | ||
| "name": "id", | ||
| "type": "long" | ||
| }, | ||
| { | ||
| "name": "is_active", | ||
| "type": "boolean" | ||
| }, | ||
| { | ||
| "name": "pii", | ||
| "type": { | ||
| "name": "UserPersonalData", | ||
| "type": "record", | ||
| "fields": [ | ||
| { | ||
| "name": "username", | ||
| "type": "string" | ||
| }, | ||
| { | ||
| "name": "email", | ||
| "type": "string" | ||
| }, | ||
| { | ||
| "name": "name", | ||
| "type": "string" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "name": "org_key", | ||
| "type": "string" | ||
| }, | ||
| { | ||
| "name": "course_key", | ||
| "type": "string" | ||
| }, | ||
| { | ||
| "name": "role", | ||
| "type": "string" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ], | ||
| "namespace": "org.openedx.learning.user.course_access_role.removed.v1" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the
ManageStudentsPermissionDataclass defined below makes me wonder if we should refrain from using the word "role" in this class name. I know you've talked to more people about the roles + permissions work though, so I trust your judgement!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. Yup the conclusion we came to was to define this as edx-platform exists today rather than trying to guess the future. I kept the name specific to the LMS model so it's use is clear instead of a ambiguous half-measure that might be reusable in the future.
There's no longer a near term path to the permission changes getting merged as we had originally wanted to account for. I'm not sure manage students will even end up being the correct permission when that the time does come to use permissions over roles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, appreciate the explanation! This looks good then 👍