Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create event for discussion events #273

Merged
merged 1 commit into from
Oct 4, 2023
Merged

feat: create event for discussion events #273

merged 1 commit into from
Oct 4, 2023

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Sep 28, 2023 •
edited
Loading

Description: This PR creates signals for events related to forum threads and comments

Extracted from: https://docs.openedx.org/en/latest/developers/references/internal_data_formats/tracking_logs/student_event_types.html#edx-forum-thread-created

This PR is the base for openedx/edx-platform#33374

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 28, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 28, 2023 •
edited
Loading

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Ian2012 force-pushed the cag/add-signal-for-thread-events branch 3 times, most recently from 9aad347 to 06b04dc Compare September 28, 2023 20:34
@Ian2012 Ian2012 marked this pull request as ready for review September 28, 2023 20:34
@Ian2012 Ian2012 requested a review from a team as a code owner September 28, 2023 20:34
@Ian2012
Copy link
Contributor Author

Ian2012 commented Sep 28, 2023

I'm still missing some events, I will let you know once this is ready

@mariajgrimaldi mariajgrimaldi marked this pull request as draft September 28, 2023 20:42
@mariajgrimaldi
Copy link
Member

I converted this PR to a draft for the time's sake

@Ian2012 Ian2012 force-pushed the cag/add-signal-for-thread-events branch from 06b04dc to 434a194 Compare September 28, 2023 20:49
@Ian2012 Ian2012 mentioned this pull request Sep 28, 2023
Closed
@Ian2012 Ian2012 force-pushed the cag/add-signal-for-thread-events branch from 36049ee to 2109b79 Compare September 29, 2023 14:33
@Ian2012 Ian2012 mentioned this pull request Sep 29, 2023
Merged
7 tasks
@Ian2012 Ian2012 marked this pull request as ready for review September 29, 2023 18:44
@Ian2012 Ian2012 force-pushed the cag/add-signal-for-thread-events branch 2 times, most recently from d55735c to a9e78da Compare September 29, 2023 19:04
mariajgrimaldi
mariajgrimaldi requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments for you to address! Thanks

openedx_events/learning/data.py Show resolved Hide resolved
openedx_events/learning/signals.py Outdated Show resolved Hide resolved
openedx_events/learning/data.py Outdated Show resolved Hide resolved
openedx_events/learning/signals.py Show resolved Hide resolved
@Ian2012 Ian2012 force-pushed the cag/add-signal-for-thread-events branch 3 times, most recently from f53fe8a to 4ca430a Compare October 2, 2023 15:06
@Ian2012 Ian2012 force-pushed the cag/add-signal-for-thread-events branch 4 times, most recently from 94c8275 to ccfedce Compare October 2, 2023 16:39
@mphilbrick211 mphilbrick211 added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Oct 2, 2023
@Ian2012 Ian2012 force-pushed the cag/add-signal-for-thread-events branch from ccfedce to fdd5b71 Compare October 2, 2023 19:53
@Ian2012 Ian2012 force-pushed the cag/add-signal-for-thread-events branch 2 times, most recently from 25fc4f6 to f158ba2 Compare October 2, 2023 20:07
This was referenced Oct 2, 2023
Merged
Closed
@Ian2012 Ian2012 force-pushed the cag/add-signal-for-thread-events branch from f158ba2 to e2fb8dc Compare October 3, 2023 16:21
@Ian2012 Ian2012 requested a review from mariajgrimaldi October 3, 2023 16:21
mariajgrimaldi
mariajgrimaldi reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last clarifying comments :)

@Ian2012 Ian2012 force-pushed the cag/add-signal-for-thread-events branch from e2fb8dc to 18f188e Compare October 3, 2023 19:06
mariajgrimaldi
mariajgrimaldi reviewed Oct 4, 2023
View reviewed changes
openedx_events/learning/signals.py Outdated
}
)

# .. event_type: org.openedx.learning.forum.response.created.v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# .. event_type: org.openedx.learning.forum.response.created.v1
# .. event_type: org.openedx.learning.forum.thread.response.created.v1

mariajgrimaldi
mariajgrimaldi reviewed Oct 4, 2023
View reviewed changes
openedx_events/learning/signals.py Outdated
}
)

# .. event_type: org.openedx.learning.forum.comment.created.v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# .. event_type: org.openedx.learning.forum.comment.created.v1
# .. event_type: org.openedx.learning.forum.response.comment.created.v1

mariajgrimaldi
mariajgrimaldi approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few comments. Thanks!

@Ian2012 Ian2012 force-pushed the cag/add-signal-for-thread-events branch 5 times, most recently from ee43a70 to ff05786 Compare October 4, 2023 18:28
@Ian2012 Ian2012 force-pushed the cag/add-signal-for-thread-events branch from ff05786 to a52ba64 Compare October 4, 2023 18:31
@mariajgrimaldi mariajgrimaldi merged commit 9443c3c into openedx:main Oct 4, 2023
6 checks passed
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariajgrimaldi mariajgrimaldi mariajgrimaldi approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ian2012 @openedx-webhooks @mariajgrimaldi @itsjeyd @mphilbrick211