Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add python 3.11 support #78

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

ichintanjoshi
Copy link
Contributor

@ichintanjoshi ichintanjoshi commented Mar 28, 2024

Description

This PR contains changes for upgrading python 3.8 to python 3.11.

Changes include :-

  • Dependencies and version upgrades
  • Extra check for fractional function to get only integers
    • This is done because fractions function in miller.py file used fr.gcd
    • Since python 3.9: The math.gcd() function is now used to normalize the numerator and denominator. math.gcd() always return a int type. Previously, the GCD type depended on numerator and denominator

Done as a part of following :-

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 28, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @ichintanjoshi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ichintanjoshi ichintanjoshi changed the title feat: add python 3.12 support feat: add python 3.11 support Mar 28, 2024
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 28, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (3765413) to head (fd7438f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files           5        5           
  Lines         622      622           
  Branches       87       81    -6     
=======================================
  Hits          611      611           
  Misses          5        5           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Apr 1, 2024
@ichintanjoshi
Copy link
Contributor Author

@feanil The tests are green now.

Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the requirements have been updated using python 3.11 env. To keep the Python 3.8 compatibility, we should run make upgrade inside python 3.8 env for now.

@ichintanjoshi
Copy link
Contributor Author

@UsamaSadiq have updated accordingly

@ichintanjoshi ichintanjoshi requested a review from UsamaSadiq April 8, 2024 07:02
@feanil feanil linked an issue Apr 22, 2024 that may be closed by this pull request
5 tasks
chem/__init__.py Outdated Show resolved Hide resolved
@feanil feanil merged commit 707b280 into openedx:master Apr 22, 2024
8 checks passed
@openedx-webhooks
Copy link

@ichintanjoshi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Test openedx-chem on Python 3.11
6 participants