feat!: typescript configuration and jest v29 upgrade #429

adamstankiewicz · 2023-07-28T16:02:11Z

No description provided.

sync: master to alpha

build: Add .ts/.tsx extensions to webpack resolver chore: Add ending newline to Image.tsx build: Use typescript config from @edx/eslint-config chore: formatting

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…files (#352)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…to v3 (#339) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

… to v2 (#310) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

sync: master to alpha

BREAKING CHANGE: Updating jest from v26 to v29 changes the default snapshotFormat.

arbrandes

No objections in principle, but I feel we should answer a couple of questions.

arbrandes · 2024-03-20T17:09:11Z

.github/workflows/commitlint.yml

+      - name: remove tsconfig.json # see issue https://github.com/conventional-changelog/commitlint/issues/3256
+        run: |
+          rm tsconfig.json


We're not going to need this, going forward. See this comment on a Paragon PR: openedx/paragon#2867 (comment)

example/tsconfig.json

arbrandes · 2024-03-20T17:15:57Z

README.md

+
+```Sample json
+{
+  "extends": "@openedx/frontend-build",


It looks like we're actually extending @edx/typescript-config in the tsconfig in this repo. Should we not recommend doing the same elsewhere?

Also, it might be good to recommend setting outDir, because I found in openedx/paragon#3016 that if you extend @edx/typescript-config but don't set outDir, when you run tsc the files will get output to ./node_modules/@edx/typescript-config/dist/ - which is not that different from sending them to /dev/null. Most people won't be running tsc (rather webpack, babel, etc.) but if they do this heads up will save them some time trying to figure out why the output is not showing up.

It looks like we're actually extending @edx/typescript-config in the tsconfig in this repo. Should we not recommend doing the same elsewhere?

@arbrandes I believe the original intent for recommending @openedx/frontend-build here was that there might be MFE-specific additions/updates we want in the base TS config available to MFEs that don't make sense in the upstream @edx/typescript-config (which, in theory, could be used for more beyond just MFEs).

For example, the base ESLint config provided to MFEs via frontend-build extends @edx/eslint-config, but slightly differs. This approach to extend @openedx/frontend-build was largely following that paradigm.

That said, if supporting MFE-only TypeScript config isn't necessary (which is probably isn't; I don't really see legacy UI repos like edx-platform adopting TypeScript anytime soon), I agree recommending to extend @edx/typescript-config directly makes more sense.

Ah, I've always wondered why typescript-config and eslint-config existed. Personally, I'd prefer to just consolidate them into frontend-build or frontend-platform.

arbrandes · 2024-03-20T17:26:28Z

Also, we need an interactive rebase on master here to consolidate the commits into a couple of meaningful ones before merging. I suggest:

One for all the Typescript stuff
One for the Jest Upgrade
One for the Renovate upgrades in package-lock

I can try and do that if there are no objections. It will require a force-push to the branch, though, so... heads up.

arbrandes · 2024-03-20T17:30:59Z

And for the future, alpha should always be treated like an integration branch (because it is). That means that we shouldn't take PRs to it directly. Instead, we should have feature branches based on master (aka PRs) that get rebased often and then octopus-merged into alpha periodically. That way it becomes relatively easy to decide to abandon a feature, or pull another one in.

Also, alpha is meant to be alpha-quality. No guarantees, and expect breaking changes. Only use it temporarily, for testing purposes.

…to bilalqamar95/alpha-eslint-update

feat: Updated eslint-config major version

sync: master to alpha

BilalQamar95 · 2024-04-05T08:10:28Z

@arbrandes With alpha synced with master, I believe this PR is ready to be reviewed/merged, it would help unblock jest v29 upgrade

* refactor: updated Readme * refactor: updated commitlint workflow file

abdullahwaheed · 2024-04-19T10:04:16Z

@arbrandes suggested changes are done, could you please review it again

arbrandes · 2024-04-19T12:35:05Z

Taking another look!

openedx-semantic-release-bot · 2024-04-19T13:13:12Z

🎉 This PR is included in version 14.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

openedx-semantic-release-bot · 2024-04-19T13:15:02Z

🎉 This PR is included in version 15.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

adamstankiewicz and others added 3 commits April 13, 2023 12:12

fix: update the README to trigger alpha release (#335)

2fab543

Merge pull request #336 from openedx/master

12dfae5

sync: master to alpha

feat: Re-enable typescript for production builds

8e64e9e

build: Add .ts/.tsx extensions to webpack resolver chore: Add ending newline to Image.tsx build: Use typescript config from @edx/eslint-config chore: formatting

adamstankiewicz changed the title ~~Alpha~~ [do not merge] alpha -> master Jul 28, 2023

renovate bot and others added 26 commits August 7, 2023 14:34

fix(deps): update dependency cssnano to v6 (#344)

cd1e726

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency html-webpack-plugin to v5.5.1

4b5d84a

fix(deps): update dependency postcss to v8.4.23

200a8ac

fix(deps): update dependency webpack-cli to v5.0.2

177d154

fix(deps): update dependency webpack-dev-server to v4.13.3

2af8b42

fix(deps): update dependency sass to v1.62.1

0edf13f

fix: disable dot rule in historyApiFallback in webpack.dev.config.js …

9908041

…files (#352)

fix(deps): update eslint (#351)

602b7a0

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency clean-webpack-plugin to v4 (#341)

357334c

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency @svgr/webpack to v7 (#340)

1c81573

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update babel monorepo

e298637

fix(deps): update dependency cssnano to v6.0.1

68457f1

fix(deps): update dependency webpack to v5.82.0 (#355)

0519c40

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency dotenv-webpack to v8 (#357)

5500920

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency postcss-loader to v7 (#358)

632a667

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update dependency typescript to v5 (#338)

4a5d559

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update peter-evans/enable-pull-request-automerge action …

5e4f2c2

…to v3 (#339) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency @edx/new-relic-source-map-webpack-plugin…

1dcd666

… to v2 (#310) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency postcss-rtlcss to v4 (#359)

30887b1

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency @svgr/webpack to v8 (#364)

70b01a5

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency webpack-cli to v5.1.1 (#363)

fa974a3

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency postcss-loader to v7.3.1 (#367)

0e20e2b

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency webpack-dev-server to v4.15.0 (#362)

d7d790c

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency eslint to v8.41.0 (#361)

e05d46b

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency style-loader to v3.3.3 (#368)

23954c4

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency sass-loader to v13 (#360)

a105af8

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

marlonkeating mentioned this pull request Oct 6, 2023

[do not merge] experimental alpha -> master #466

Closed

This was referenced Oct 24, 2023

[do not merge] experimental alpha -> master #473

Closed

[do not merge] experimental alpha -> master #474

Draft

abdullahwaheed and others added 4 commits March 19, 2024 17:41

feat: sync alhpa with master (#520)

a1bb895

Merge branch 'master' of github.com:openedx/frontend-build into alpha

bd87fa6

Merge pull request #521 from openedx/master

5779e9f

sync: master to alpha

feat!: updated jest to v29 (#415)

c6372b7

BREAKING CHANGE: Updating jest from v26 to v29 changes the default snapshotFormat.

arbrandes self-requested a review March 20, 2024 17:03

arbrandes requested changes Mar 20, 2024

View reviewed changes

BilalQamar95 and others added 6 commits March 27, 2024 15:31

refactor: updated eslint-config

caa1ff7

Merge branch 'master' of https://github.com/openedx/frontend-build in…

088ada9

…to bilalqamar95/alpha-eslint-update

refactor: updated eslint-config

f325dca

refactor: updated tsconfig to resolve parsing error

4ba4acf

Merge pull request #530 from openedx/bilalqamar95/alpha-eslint-update

11d1cab

feat: Updated eslint-config major version

Merge pull request #524 from openedx/master

2c4ef22

sync: master to alpha

BilalQamar95 mentioned this pull request Apr 19, 2024

Readme and workflow updates #532

Merged

refactor: Readme and workflow updates (#532)

3dfca7d

* refactor: updated Readme * refactor: updated commitlint workflow file

abdullahwaheed changed the title ~~[do not merge] alpha -> master~~ feat!: typescript configuration and jest v29 upgrade Apr 19, 2024

abdullahwaheed marked this pull request as ready for review April 19, 2024 10:03

abdullahwaheed requested a review from arbrandes April 19, 2024 10:03

arbrandes merged commit 91c6ce4 into master Apr 19, 2024
5 of 6 checks passed

openedx-semantic-release-bot added the released label Apr 19, 2024

openedx-semantic-release-bot added the released on @alpha label Apr 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: typescript configuration and jest v29 upgrade #429

feat!: typescript configuration and jest v29 upgrade #429

adamstankiewicz commented Jul 28, 2023

arbrandes left a comment

arbrandes Mar 20, 2024

arbrandes Mar 20, 2024

bradenmacdonald Mar 22, 2024

adamstankiewicz Apr 9, 2024

bradenmacdonald Apr 9, 2024

arbrandes commented Mar 20, 2024 •

edited

Loading

arbrandes commented Mar 20, 2024

BilalQamar95 commented Apr 5, 2024

abdullahwaheed commented Apr 19, 2024

arbrandes commented Apr 19, 2024

openedx-semantic-release-bot commented Apr 19, 2024

openedx-semantic-release-bot commented Apr 19, 2024

feat!: typescript configuration and jest v29 upgrade #429

feat!: typescript configuration and jest v29 upgrade #429

Conversation

adamstankiewicz commented Jul 28, 2023

arbrandes left a comment

Choose a reason for hiding this comment

arbrandes Mar 20, 2024

Choose a reason for hiding this comment

arbrandes Mar 20, 2024

Choose a reason for hiding this comment

bradenmacdonald Mar 22, 2024

Choose a reason for hiding this comment

adamstankiewicz Apr 9, 2024

Choose a reason for hiding this comment

bradenmacdonald Apr 9, 2024

Choose a reason for hiding this comment

arbrandes commented Mar 20, 2024 • edited Loading

arbrandes commented Mar 20, 2024

BilalQamar95 commented Apr 5, 2024

abdullahwaheed commented Apr 19, 2024

arbrandes commented Apr 19, 2024

openedx-semantic-release-bot commented Apr 19, 2024

openedx-semantic-release-bot commented Apr 19, 2024

arbrandes commented Mar 20, 2024 •

edited

Loading