fix: associated catalog selection bug in prod #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #358 +/- ##
==========================================
- Coverage 88.40% 88.40% -0.01%
==========================================
Files 161 161
Lines 3416 3414 -2
Branches 843 841 -2
==========================================
- Hits 3020 3018 -2
Misses 393 393
Partials 3 3
☔ View full report in Codecov by Sentry. |
marlonkeating
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The provisioning tool's edit view renders the associated catalog selection based on the
PREDEFINED_CATALOG_QUERIES. However, currently in prod, the associated catalog isn't rendering correctly for single budget plans due to a code discrepancy. The code was originally matching the data returned from the enterprise catalogs service with the stagedPREDEFINED_CATALOG_QUERIES, which differs from the production environment.Solution
To address this issue, update the matching logic to utilize the config attribute, which will correctly identify the
PREDEFINED_CATALOG_QUERIESregardless of the environment.https://2u-internal.atlassian.net/browse/ENT-7784