feat: hide studio button for limited staff [BB-9082]

[0x29a]

Description

Partially addresses openedx/platform-roadmap#361 issue, by implementing the second suggestion from here:

Limited Staff should not see the button to "view this course in Studio" from the LMS. This will reduce chances for Limited Staff to land on Studio pages.

This fix relies on openedx/edx-platform#35313.

Testing

1. Create two users, [email protected] and [email protected].
2. In the instructor's dashboard, assign [email protected] user to the staff course access role, and [email protected] to the limited staff course access role.
3. Verify that the limited staff user doesn't see "View in Studio" button. Cycle through different roles in "View this course as:" dropdown and verify that none can see this button.
4. The same as №3, but staff user should see this button always.

[openedx-webhooks]

Thanks for the pull request, @0x29a!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-app-learning. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.77%. Comparing base (7cbbc72) to head (c3cd7da).
Report is 55 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1436      +/-   ##
==========================================
+ Coverage   87.70%   87.77%   +0.07%     
==========================================
  Files         307      310       +3     
  Lines        5288     5319      +31     
  Branches     1311     1315       +4     
==========================================
+ Hits         4638     4669      +31     
  Misses        633      633              
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kaustavb12]

LGTM 👍

• I tested this: Tested in local devstack
• I read through the code

[itsjeyd]

OSPR management note: User-facing change, so will likely need product approval before we can move forward with engineering review and merge.

Marking as blocked for now.

CC @openedx/committers-frontend-app-learning

[itsjeyd]

@0x29a It looks like the conversation about how to proceed with this PR and openedx/edx-platform#35313 stalled, so I went ahead and brought it up in the #wg-product-core channel on the Open edX Slack. Could you please watch that thread and follow up as necessary?

CC @openedx/committers-frontend-app-learning @mphilbrick211

[itsjeyd]

OSPR management note: Product review complete, see openedx/platform-roadmap#361 (comment).

[itsjeyd]

@openedx/committers-frontend-app-learning This is ready for engineering review. Since it relies on openedx/edx-platform#35313 it would be great if you could have a look at that PR as well.

[farhaanbukhsh]

@itsjeyd I will review this PR :)

[itsjeyd]

Thanks @farhaanbukhsh!

[farhaanbukhsh]

@0x29a is a small nitpick but once we fix this we are good to go.

[farhaanbukhsh]

Suggested change

	studioButtonVisible={hasCourseAuthorAccess}
	isStudioButtonVisible={hasCourseAuthorAccess}

[itsjeyd]

@farhaanbukhsh Looks like this is ready for final 👍 and merge :)

[farhaanbukhsh]

👍

• ✅ I tested this on tutor devstack and all the flags are working properly
• ✅ I read through the code
• ❌ I checked for accessibility issues
• ❌ Includes documentation
• ❌ I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.