Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrectly named plugin slots #1388

Merged
merged 1 commit into from
May 16, 2024
Merged

fix: incorrectly named plugin slots #1388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/course-home/outline-tab/OutlineTab.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ const OutlineTab = ({ intl }) => {
)}
<CourseTools />
<PluginSlot
id="outline_tab_notifications_plugin"
id="outline_tab_notifications_slot"
pluginProps={{ courseId }}
>
<UpgradeNotification
Expand Down
4 changes: 2 additions & 2 deletions src/course-home/outline-tab/OutlineTab.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,14 @@ describe('Outline Tab', () => {
expect(expandedSectionNode).toHaveAttribute('aria-expanded', 'true');
});

it('includes outline_tab_notifications_plugin slot', async () => {
it('includes outline_tab_notifications_slot', async () => {
const { courseBlocks } = await buildMinimalCourseBlocks(courseId, 'Title', { resumeBlock: true });
setTabData({
course_blocks: { blocks: courseBlocks.blocks },
});
await fetchAndRender();

expect(screen.getByTestId('outline_tab_notifications_plugin')).toBeInTheDocument();
expect(screen.getByTestId('outline_tab_notifications_slot')).toBeInTheDocument();
});

it('handles expand/collapse all button click', async () => {
Expand Down
2 changes: 1 addition & 1 deletion src/courseware/course/sidebar/sidebars/notifications/NotificationTray.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ const NotificationTray = ({ intl }) => {
<div>{verifiedMode
? (
<PluginSlot
id="notification_tray_plugin"
id="notification_tray_slot"
pluginProps={{
courseId,
notificationCurrentState: upgradeNotificationCurrentState,
Expand Down
4 changes: 2 additions & 2 deletions src/courseware/course/sidebar/sidebars/notifications/NotificationTray.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ describe('NotificationTray', () => {
.toBeInTheDocument();
});

it('includes notification_tray_plugin slot', async () => {
it('includes notification_tray_slot', async () => {
await fetchAndRender(
<SidebarContext.Provider value={{
currentSidebar: ID,
Expand All @@ -91,7 +91,7 @@ describe('NotificationTray', () => {
<NotificationTray />
</SidebarContext.Provider>,
);
expect(screen.getByTestId('notification_tray_plugin')).toBeInTheDocument();
expect(screen.getByTestId('notification_tray_slot')).toBeInTheDocument();
});

it('renders upgrade card', async () => {
Expand Down
Loading