Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrates license activation and auto-apply to route loaders, plus general cleanup #990

Merged
merged 19 commits into from
Mar 7, 2024

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Mar 4, 2024

Description

https://2u-internal.atlassian.net/browse/ENT-8480

Related PRs:

Changelog

  • Removes the Route associated with the makeUpdateActiveEnterpriseCustomerUserLoader loader; the loader's logic is migrated into rootLoader to simplify routing structure.
  • Handles subscription license activation for any assigned licenses before any UI is shown and during route transitions.
  • Handles auto-applied subscription licenses for configured integrated customers before any UI is shown and during route transitions.
  • Ensures the enterpriseCustomer metadata is transformed in all the places (was previously missing when switching active customers).
  • Removes all prior code related to auto-activation and auto-application of subscription licenses now that its been migrated to route loader paradigm.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Sorry, something went wrong.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 82.32190% with 67 lines in your changes are missing coverage. Please review.

Project coverage is 84.02%. Comparing base (dd6e06e) to head (cb35436).

Files Patch % Lines
src/components/app/routes/data/utils.js 28.94% 23 Missing and 4 partials ⚠️
src/components/app/data/utils.js 73.84% 17 Missing ⚠️
...components/app/data/queries/extractEnterpriseId.js 0.00% 9 Missing and 2 partials ⚠️
...nents/app/data/services/subsidies/subscriptions.js 93.05% 5 Missing ⚠️
src/components/app/routes/loaders/rootLoader.js 57.14% 3 Missing ⚠️
src/components/app/data/services/course.js 91.66% 2 Missing ⚠️
.../components/app/data/services/contentHighlights.js 90.90% 1 Missing ⚠️
...ts/app/data/services/subsidies/browseAndRequest.js 95.65% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##           feat/react-query-route-loaders     #990      +/-   ##
==================================================================
+ Coverage                           81.42%   84.02%   +2.59%     
==================================================================
  Files                                 374      365       -9     
  Lines                                7800     7791       -9     
  Branches                             1898     1900       +2     
==================================================================
+ Hits                                 6351     6546     +195     
+ Misses                               1393     1202     -191     
+ Partials                               56       43      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz changed the base branch from feat/react-query-route-loaders to ags/notices-blip March 6, 2024 02:50
* feat: refactor notices provider to useQuery

* chore: merge fix

* chore: cleanup

* fix: redirects without momentary render

* fix: debugging

* chore: Testing and cleanup

* chore: PR feedback
@adamstankiewicz adamstankiewicz changed the base branch from ags/notices-blip to feat/react-query-route-loaders March 6, 2024 02:57
@adamstankiewicz adamstankiewicz marked this pull request as ready for review March 7, 2024 06:48
@adamstankiewicz adamstankiewicz changed the title feat: migrates license activation and auto-apply to route loaders feat: migrates license activation and auto-apply to route loaders, plus general cleanup Mar 7, 2024
@adamstankiewicz adamstankiewicz merged commit 68eb524 into feat/react-query-route-loaders Mar 7, 2024
7 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/ent-8480 branch March 7, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants