-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrates license activation and auto-apply to route loaders, plus general cleanup #990
Merged
+2,698
−2,185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/react-query-route-loaders #990 +/- ##
==================================================================
+ Coverage 81.42% 84.02% +2.59%
==================================================================
Files 374 365 -9
Lines 7800 7791 -9
Branches 1898 1900 +2
==================================================================
+ Hits 6351 6546 +195
+ Misses 1393 1202 -191
+ Partials 56 43 -13 ☔ View full report in Codecov by Sentry. |
adamstankiewicz
changed the base branch from
feat/react-query-route-loaders
to
ags/notices-blip
March 6, 2024 02:50
* feat: refactor notices provider to useQuery * chore: merge fix * chore: cleanup * fix: redirects without momentary render * fix: debugging * chore: Testing and cleanup * chore: PR feedback
adamstankiewicz
changed the base branch from
ags/notices-blip
to
feat/react-query-route-loaders
March 6, 2024 02:57
adamstankiewicz
changed the title
feat: migrates license activation and auto-apply to route loaders
feat: migrates license activation and auto-apply to route loaders, plus general cleanup
Mar 7, 2024
brobro10000
approved these changes
Mar 7, 2024
adamstankiewicz
merged commit Mar 7, 2024
68eb524
into
feat/react-query-route-loaders
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://2u-internal.atlassian.net/browse/ENT-8480
Related PRs:
Changelog
Route
associated with themakeUpdateActiveEnterpriseCustomerUserLoader
loader; the loader's logic is migrated intorootLoader
to simplify routing structure.enterpriseCustomer
metadata is transformed in all the places (was previously missing when switching active customers).For all changes
Only if submitting a visual change