feat: use frontend-plugin-framework to provide a FooterSlot #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for writing this up, Braden! The @openedx/2u-aperture team and I will be looking over this PR early next week, while also monitoring the conversation for Learning MFE's PR. |
brian-smith-tcril
force-pushed
the
footer-slot
branch
4 times, most recently
from
0fb1fc6 to
2c5ae41
Compare
arbrandes
approved these changes
May 17, 2024
| @@ -109,7 +109,7 @@ export const App = () => { | |||
| )} | |||
| </main> | |||
| </AppWrapper> | |||
| <Footer logo={getConfig().LOGO_POWERED_BY_OPEN_EDX_URL_SVG} /> | |||
| <FooterSlot /> | |||
There was a problem hiding this comment.
Can you please also remove the var from https://github.com/openedx/frontend-app-learner-dashboard/blob/master/.env.development#L11? and https://github.com/openedx/frontend-app-learner-dashboard/blob/master/.env.test#L11?
brian-smith-tcril
force-pushed
the
footer-slot
branch
from
2c5ae41 to
88e80e7
Compare
brian-smith-tcril
force-pushed
the
footer-slot
branch
from
88e80e7 to
17eff1d
Compare
jsnwesson
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This removes the ability to use
LOGO_POWERED_BY_OPEN_EDX_URL_SVGto set the logo in the footer. The footer component itself supports usingLOGO_TRADEMARK_URLto set the logo.Note: There are other
PluginSlotsin this MFE that have not been moved to theplugin-slotsdirectory and turned into components yet. I wanted to keep the focus of this PR on adding theFooterSlot, so I created an issue to track that effort #344 and will PR those changes separately