feat: set up dashboard to deploy js configs #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 182 182
Lines 1747 1747
Branches 308 308
=======================================
Hits 1688 1688
Misses 55 55
Partials 4 4 ☔ View full report in Codecov by Sentry. |
MaxFrank13
approved these changes
Mar 28, 2024
src/config/index.js
Outdated
Comment on lines
26
to
28
| // This mergeConfig ensures that any variables assigned by process.env are still overwritten if declared in JS config | ||
| mergeConfig(envConfig); | ||
|
|
There was a problem hiding this comment.
Does this not already happen in frontend-platform?
There was a problem hiding this comment.
You're right, it does, and I realize now that I added this additional mergeConfig because at one point I was trying to handle the scenario where the .env.* files would be removed, but I now know that that isn't something I should have to anticipate while adding the risk of variables over-writing each other repeatedly. Removing this logic for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a patch in Learner Dashboard's
frontend-builddependency that allows for JS configs to be handled in a production build. This also includes further handling in the Jest config to accept both JS and JSX configs.setupTest.jsdue to there being no plans to remove.env.testin the near futuremergeConfiginconfiguration.jsto ensure JS config variables will still overwrite any previously-assignedprocess.envvariables. (this aligns with the predictable order of environment variable assignment in frontend-build)APER-3085
Scenarios I tested for (via
npm run testandnpm run start:env.config.jsexists,.env.*files untouchedenv.config.jsfile exists and.env.*files untouched