-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add component Details sidebar [FC-0062] #1303
feat: add component Details sidebar [FC-0062] #1303
Conversation
Thanks for the pull request, @rpenido! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
a6a7b73
to
c106f87
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1303 +/- ##
==========================================
+ Coverage 92.47% 92.73% +0.25%
==========================================
Files 1025 1035 +10
Lines 18978 19261 +283
Branches 4048 4079 +31
==========================================
+ Hits 17550 17861 +311
+ Misses 1360 1335 -25
+ Partials 68 65 -3 ☔ View full report in Codecov by Sentry. |
1a4df25
to
cbed007
Compare
@@ -9,7 +9,7 @@ import { mockLibraryBlockMetadata } from '../data/api.mocks'; | |||
import ComponentManagement from './ComponentManagement'; | |||
|
|||
/* | |||
* FIXME: Summarize the reason here | |||
* This function is used to get the inner text of an element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed comment from the ComponentManagent tab test
cbed007
to
1788a4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, but 👍 when that's fixed :)
- I tested this using the PR test instructions
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
-
Includes documentationN/A - User-facing strings are extracted for translation
Co-authored-by: Jillian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpenido Looks good 👍 One small nit, but not a blocker.
|
||
// istanbul ignore if: this should never happen | ||
if (!componentMetadata) { | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can throw an error instead of null
. (ex.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
596b87a
to
ab22ed8
Compare
ab22ed8
to
a9a7b21
Compare
Description
This PR adds the
Details
tab in the Component Sidebar.More information
Part of:
Depends on:
Testing Instructions
Details
tabPrivate ref: FAL-3803