Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change toast component [FC-0059] #1211

Merged
merged 1 commit into from
Aug 22, 2024
Merged

refactor: change toast component [FC-0059] #1211

merged 1 commit into from
Aug 22, 2024
+19 −8

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Aug 13, 2024 •
edited
Loading

Description

Change the Toast component used in our toast-context to match the existing element in course authoring.

More information

This change came from a UI/UX review comment.

Testing Instructions

  • Create a new library v2
  • Add components to this library (Text, Problems or Video; Drag and Drop is NOT supported right now)
  • Select the "Copy to clipboard" option in the card menu
  • A toast must show "Component copied to clipboard"

Private ref: FAL-3769

Settings

TUTOR_GROVE_MFE_LMS_COMMON_SETTINGS: |
  MFE_CONFIG["LIBRARY_MODE"] = "mixed"

PLUGINS:
- mfe
- grove
- meilisearch
- s3

Tutor requirements

git+https://github.com/overhangio/tutor.git@nightly
git+https://github.com/overhangio/tutor-mfe@nightly
git+https://github.com/open-craft/tutor-contrib-meilisearch.git@main
git+https://github.com/hastexo/[email protected]
git+https://gitlab.com/opencraft/dev/tutor-contrib-grove.git@main

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 13, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 13, 2024 •
edited
Loading

Thanks for the pull request, @rpenido!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov Codecov
Copy link

codecov bot commented Aug 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.02%. Comparing base (7c59b4a) to head (912df79).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1211      +/-   ##
==========================================
+ Coverage   92.99%   93.02%   +0.03%     
==========================================
  Files         756      756              
  Lines       13653    13698      +45     
  Branches     2953     2966      +13     
==========================================
+ Hits        12696    12742      +46     
+ Misses        921      920       -1     
  Partials       36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpenido rpenido force-pushed the rpenido/fal-3769-change-toast-design branch from 2631fec to 44b4e1d Compare August 13, 2024 22:37
@rpenido rpenido added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Aug 13, 2024
@rpenido rpenido force-pushed the rpenido/fal-3769-change-toast-design branch 3 times, most recently from 5f5b13c to 22b8498 Compare August 14, 2024 17:58
@rpenido rpenido marked this pull request as ready for review August 15, 2024 13:50
@rpenido rpenido requested a review from a team as a code owner August 15, 2024 13:50
@rpenido rpenido requested a review from yusuf-musleh August 15, 2024 13:51
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Aug 15, 2024
yusuf-musleh
yusuf-musleh approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@yusuf-musleh yusuf-musleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good and works well, thanks @rpenido !

  • I tested this: Followed testing instructions in PR
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@rpenido rpenido force-pushed the rpenido/fal-3769-change-toast-design branch from 22b8498 to 912df79 Compare August 16, 2024 16:21
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@rpenido rpenido requested a review from ChrisChV August 21, 2024 19:58
@rpenido
Copy link
Contributor Author

rpenido commented Aug 21, 2024

Hi @ChrisChV!
The issue related to this change was closed as we have the approval on the sandbox, but this wasn't merged yet,
Could you please review/merge this?

Thank you!

@ChrisChV ChrisChV merged commit 21c9e30 into openedx:master Aug 22, 2024
7 checks passed
@openedx-webhooks
Copy link

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@ChrisChV ChrisChV deleted the rpenido/fal-3769-change-toast-design branch August 22, 2024 13:51
@bradenmacdonald bradenmacdonald mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisChV ChrisChV ChrisChV approved these changes

@yusuf-musleh yusuf-musleh yusuf-musleh approved these changes

Assignees
No one assigned
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rpenido @openedx-webhooks @open-craft-grove @yusuf-musleh @ChrisChV @mphilbrick211