fix: Authn pages - fix background on medium resolutions [master]

[Lunyachek]

Description

At some resolutions, we can see this bug. It's related to the SVG image having a specific height, and at certain page sizes, this height isn't enough for the SVG to reach the bottom of the page. We suggest drawing a slanted background using CSS

How Has This Been Tested?

Locally, in different browsers and resolutions (Screenshots below)

Before

After

Merge Checklist

• If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
• Is there adequate test coverage for your changes?

Post-merge Checklist

• Deploy the changes to prod after verifying on stage or ask @openedx/2u-vanguards to do it.
• 🎉 🙌 Celebrate! Thanks for your contribution.

[openedx-webhooks]

Thanks for the pull request, @Lunyachek!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-infinity. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (90ae870) to head (2d96064).
Report is 7 commits behind head on master.

❗ Current head 2d96064 differs from pull request most recent head 5b1e63a. Consider uploading reports for the commit 5b1e63a to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1192      +/-   ##
==========================================
- Coverage   87.71%   84.26%   -3.46%     
==========================================
  Files         124      126       +2     
  Lines        2288     2390     +102     
  Branches      636      678      +42     
==========================================
+ Hits         2007     2014       +7     
- Misses        272      356      +84     
- Partials        9       20      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[arbrandes]

I'm certainly in favor in principle, but is there any chance you could post screenshots of results on the major browsers (Chrome, Safari, Edge, Firefox)?

[zainab-amir]

@Lunyachek can you kindly rebase your branch.

[Lunyachek]

@Lunyachek can you kindly rebase your branch.

Rebased. But I want to take more time to investigate one more small bug. I started taking screenshots in different browsers at different resolutions and found a strange bug with a vertical line.

[mphilbrick211]

Hi @Lunyachek! Just checking to see if this pull request is still being worked on?

[mphilbrick211]

@Lunyachek - following up on this!

[mphilbrick211]

Hi @openedx/2u-infinity! Would someone be able to take a look at this. It's been stalled for a bit.

[Lunyachek]

Hello @mphilbrick211 I don’t have a good solution at the moment. Can we close the PR for now, and if I come up with a solution, I’ll reopen it?

[mphilbrick211]

Closing per comment above.