Fix TPA skeleton loader #1189
Merged
Fix TPA skeleton loader #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zainab-amir
force-pushed
the
zamir/VAN-1837/fix_tpa_skeleton
branch
from
6aab063 to
1227568
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1189 +/- ##
==========================================
+ Coverage 84.20% 84.22% +0.01%
==========================================
Files 126 126
Lines 2393 2396 +3
Branches 679 680 +1
==========================================
+ Hits 2015 2018 +3
Misses 358 358
Partials 20 20 ☔ View full report in Codecov by Sentry. |
zainab-amir
force-pushed
the
zamir/VAN-1837/fix_tpa_skeleton
branch
from
1227568 to
7173933
Compare
arbrandes
requested changes
Mar 5, 2024
| <Icon src={Institution} className="institute-icon" /> | ||
| {formatMessage(messages['enterprise.login.btn.text'])} | ||
| </Hyperlink> | ||
| )} | ||
|
|
||
| {thirdPartyAuthApiStatus === PENDING_STATE ? ( | ||
| <Skeleton className="tpa-skeleton" height={36} count={2} /> | ||
| {thirdPartyAuthApiStatus === PENDING_STATE || true ? ( |
There was a problem hiding this comment.
If I'm not mistaken, this expression will always evaluate to true because === has a higher precedence than || (reference). Is it the intended behavior?
There was a problem hiding this comment.
This was my testing code and was accidentally merged. The latest commit in the PR doesn't have it.
syedsajjadkazmii
approved these changes
Mar 6, 2024
zainab-amir
force-pushed
the
zamir/VAN-1837/fix_tpa_skeleton
branch
from
380c7c4 to
3b6778e
Compare
arbrandes
approved these changes
Mar 6, 2024
4 tasks
syedsajjadkazmii
pushed a commit
to DmytroAlipov/frontend-app-authn
that referenced
this pull request
Mar 11, 2024
* feat: update TPA skeleton * fix: Prevent wrong appearance of skeleton after second tab click --------- Co-authored-by: Stanislav Lunyachek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are two changes in this PR
JIRA
VAN-1837
How Has This Been Tested?
Locally
Screenshots/sandbox (optional):
Merge Checklist
Post-merge Checklist