fix: moved registration tests to specific files. #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attiyaIshaque
force-pushed
the
attiya/VAN-1628-refactor-tests
branch
2 times, most recently
from
f09d5f6 to
7fe3d3e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1104 +/- ##
==========================================
+ Coverage 87.05% 87.08% +0.02%
==========================================
Files 124 124
Lines 2271 2276 +5
Branches 629 634 +5
==========================================
+ Hits 1977 1982 +5
Misses 285 285
Partials 9 9 ☔ View full report in Codecov by Sentry. |
attiyaIshaque
force-pushed
the
attiya/VAN-1628-refactor-tests
branch
from
7fe3d3e to
4fc3eac
Compare
| @@ -153,11 +148,7 @@ describe('RegistrationPage', () => { | |||
| }; | |||
|
|
|||
| const ssoProvider = { | |||
There was a problem hiding this comment.
Do we still need to pass ssoProvider in formPayload? Reference line 216.
There was a problem hiding this comment.
Nope, we don't need this. Thanks for pointing this out.
Comment on lines
+113
to
+116
| config: { | ||
| ENVIRONMENT: 'production', | ||
| LANGUAGE_PREFERENCE_COOKIE_NAME: 'yum', | ||
| }, |
There was a problem hiding this comment.
Do we need these configs?
There was a problem hiding this comment.
Yes. we can't Pass ENVIRONMENT undefined.
Comment on lines
131
to
133
| mergeConfig({ | ||
| SHOW_CONFIGURABLE_EDX_FIELDS: true, | ||
| }); |
There was a problem hiding this comment.
Also what about these?
There was a problem hiding this comment.
I have removed these.
attiyaIshaque
force-pushed
the
attiya/VAN-1628-refactor-tests
branch
from
4fc3eac to
497db70
Compare
mubbsharanwar
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All tests that are not directly related to the registration form functionality have been moved to their respective component-specific test files.
JIRA
VAN-1628