-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent wrong appearance of skeleton after second tab click #1086
fix: Prevent wrong appearance of skeleton after second tab click #1086
Conversation
Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
517f2df
to
4c7ed60
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1086 +/- ##
==========================================
- Coverage 86.98% 86.94% -0.04%
==========================================
Files 124 124
Lines 2266 2268 +2
Branches 624 625 +1
==========================================
+ Hits 1971 1972 +1
- Misses 286 287 +1
Partials 9 9
☔ View full report in Codecov by Sentry. |
Hi @Lunyachek - would you mind trying rebasing to see if it gets rid of the codecov errors? If it doesn't work, I'll look into it for you. |
We have created a ticket in our backlog to review this change. We will be able to get back to your with a review within this quarter. |
@Lunyachek will you be able to rebase your branch? Unfortunately I don't have access to make edits. |
Hi @Lunyachek, |
@Lunyachek Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Thank you a lot! |
Description
We found that after clicking twice on the same tab - skeleton appeared and not disappeared till switching other tab or page refresh. We think that it is not logical and our proposal - this minor fix
Before fix:
2023-10-21.22.00.50-2.mov
After fix:
2023-10-21.22.03.33.mov
Merge Checklist
Post-merge Checklist