Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent wrong appearance of skeleton after second tab click #1086

Conversation

Lunyachek
Copy link
Contributor

Description

We found that after clicking twice on the same tab - skeleton appeared and not disappeared till switching other tab or page refresh. We think that it is not logical and our proposal - this minor fix

Before fix:

2023-10-21.22.00.50-2.mov

After fix:

2023-10-21.22.03.33.mov

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/vanguards to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@Lunyachek Lunyachek requested a review from a team as a code owner October 21, 2023 19:19
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 21, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 21, 2023

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Lunyachek Lunyachek force-pushed the lunyachek/fix/non-logical-skeleton-appearance-master branch from 517f2df to 4c7ed60 Compare October 27, 2023 14:48
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (38c186d) 86.98% compared to head (4c7ed60) 86.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1086      +/-   ##
==========================================
- Coverage   86.98%   86.94%   -0.04%     
==========================================
  Files         124      124              
  Lines        2266     2268       +2     
  Branches      624      625       +1     
==========================================
+ Hits         1971     1972       +1     
- Misses        286      287       +1     
  Partials        9        9              
Files Coverage Δ
src/logistration/Logistration.jsx 95.00% <75.00%> (-1.56%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211
Copy link

Hi @Lunyachek - would you mind trying rebasing to see if it gets rid of the codecov errors? If it doesn't work, I'll look into it for you.

@zainab-amir
Copy link
Contributor

We have created a ticket in our backlog to review this change. We will be able to get back to your with a review within this quarter.
Thank you!

@zainab-amir
Copy link
Contributor

@Lunyachek will you be able to rebase your branch? Unfortunately I don't have access to make edits.

@zainab-amir zainab-amir mentioned this pull request Mar 5, 2024
4 tasks
@zainab-amir
Copy link
Contributor

Hi @Lunyachek,
Since I didn't hear back from you, I cherry picked your commit in #1189 and have added test too.

@zainab-amir zainab-amir closed this Mar 6, 2024
@openedx-webhooks
Copy link

@Lunyachek Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@Lunyachek
Copy link
Contributor Author

Hi @Lunyachek, Since I didn't hear back from you, I cherry picked your commit in #1189 and have added test too.

Thank you a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants