Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pagination for reporting configs list #1361

Closed
wants to merge 2 commits into from

Conversation

omar-sarfraz
Copy link
Member

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots
image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 28, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @omar-sarfraz!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently unmaintained.

To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:

  1. On the right-hand side of the PR, find the Contributions project, click the caret in the top right corner to expand it, and check the "Primary PM" field for the name of your PM.
  2. Find their GitHub handle here.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@omar-sarfraz
Copy link
Member Author

This PR depends upon https://github.com/openedx/edx-enterprise/pull/2292

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Dec 2, 2024
@mphilbrick211
Copy link

Hi @omar-sarfraz, thank you for this contribution! Please let me know if you have any questions regarding submitting a CLA form. Thanks!

@omar-sarfraz
Copy link
Member Author

Hi @mphilbrick211, I've recently joined Enterprise Markhors team from 2U. I'm not sure about the proper CLA process, can you help me in this regard?

@mphilbrick211
Copy link

Hi @mphilbrick211, I've recently joined Enterprise Markhors team from 2U. I'm not sure about the proper CLA process, can you help me in this regard?

Thanks, @omar-sarfraz! You can have your manager reach out to [email protected] to have you added to our existing 2U entity agreement.

@omar-sarfraz
Copy link
Member Author

@mphilbrick211 Thanks a lot for this information.

@e0d
Copy link

e0d commented Dec 7, 2024

@omar-sarfraz it looks like there are conflicts here that need to be resolved. I'll run the tests anyway, but please have a look when you can.

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 59.37500% with 13 lines in your changes missing coverage. Please review.

Project coverage is 85.51%. Comparing base (c9bd93f) to head (f71dd16).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/components/ReportingConfig/index.jsx 70.37% 8 Missing ⚠️
src/data/services/LmsApiService.js 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1361      +/-   ##
==========================================
- Coverage   85.55%   85.51%   -0.05%     
==========================================
  Files         603      603              
  Lines       13268    13290      +22     
  Branches     2756     2810      +54     
==========================================
+ Hits        11352    11365      +13     
- Misses       1851     1858       +7     
- Partials       65       67       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omar-sarfraz
Copy link
Member Author

Closing this PR as this functionality is implemented in another PR.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants