-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pagination for reporting configs list #1361
Conversation
Thanks for the pull request, @omar-sarfraz! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently unmaintained. To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
This PR depends upon https://github.com/openedx/edx-enterprise/pull/2292 |
Hi @omar-sarfraz, thank you for this contribution! Please let me know if you have any questions regarding submitting a CLA form. Thanks! |
Hi @mphilbrick211, I've recently joined Enterprise Markhors team from 2U. I'm not sure about the proper CLA process, can you help me in this regard? |
Thanks, @omar-sarfraz! You can have your manager reach out to [email protected] to have you added to our existing 2U entity agreement. |
@mphilbrick211 Thanks a lot for this information. |
@omar-sarfraz it looks like there are conflicts here that need to be resolved. I'll run the tests anyway, but please have a look when you can. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1361 +/- ##
==========================================
- Coverage 85.55% 85.51% -0.05%
==========================================
Files 603 603
Lines 13268 13290 +22
Branches 2756 2810 +54
==========================================
+ Hits 11352 11365 +13
- Misses 1851 1858 +7
- Partials 65 67 +2 ☔ View full report in Codecov by Sentry. |
Closing this PR as this functionality is implemented in another PR. |
For all changes
Only if submitting a visual change