Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated README file to reflect template changes #1075

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

Mashal-m
Copy link
Contributor

Description

The README of the MFEs needs to be updated because the frontend app template has been updated.

Issue related: openedx/wg-frontend#169

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3aa2e64) 84.14% compared to head (1c6d12f) 84.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1075   +/-   ##
=======================================
  Coverage   84.14%   84.14%           
=======================================
  Files         455      455           
  Lines        9560     9560           
  Branches     1992     1992           
=======================================
  Hits         8044     8044           
  Misses       1474     1474           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m merged commit 1224e74 into master Nov 1, 2023
6 checks passed
@Mashal-m Mashal-m deleted the mashal-m/update-README branch November 1, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants