Revert "fix(deps): update dependency @edx/frontend-platform to v5.3.0" #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 757e446.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #870 +/- ##
=======================================
Coverage 46.54% 46.54%
=======================================
Files 122 122
Lines 2548 2548
Branches 669 669
=======================================
Hits 1186 1186
Misses 1286 1286
Partials 76 76 ☔ View full report in Codecov by Sentry. |
Syed-Ali-Abbas-Zaidi
approved these changes
Sep 5, 2023
abdullahwaheed
deleted the
revert-867-renovate/edx-frontend-platform-5.x
branch
|
@Syed-Ali-Abbas-Zaidi, @abdullahwaheed, I didn't catch this locally, apologies. Let's figure out the best strategy: react-redux 8 is not supposed to be a breaking change, so if I'm reading this right we "just" have to bump the peer deps. |
abdullahwaheed
added a commit
that referenced
this pull request
Sep 21, 2023
* feat: add toggling for the hardcode support link (master) Add a toggling mechanism for the "unlink all social media accounts" text to show it as a link or text depending on the MFE env setting. * fix(deps): update dependency @edx/frontend-platform to v5.3.0 * Revert "fix(deps): update dependency @edx/frontend-platform to v5.3.0" (#870) This reverts commit 757e446. * feat: add toggling for the hardcode support link (master) Add a toggling mechanism for the "unlink all social media accounts" text to show it as a link or text depending on the MFE env setting. --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Muhammad Abdullah Waheed <[email protected]>
snglth
pushed a commit
to Abstract-Tech/community-theme-account
that referenced
this pull request
Jan 9, 2024
…x#864) * feat: add toggling for the hardcode support link (master) Add a toggling mechanism for the "unlink all social media accounts" text to show it as a link or text depending on the MFE env setting. * fix(deps): update dependency @edx/frontend-platform to v5.3.0 * Revert "fix(deps): update dependency @edx/frontend-platform to v5.3.0" (openedx#870) This reverts commit 757e446. * feat: add toggling for the hardcode support link (master) Add a toggling mechanism for the "unlink all social media accounts" text to show it as a link or text depending on the MFE env setting. --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Muhammad Abdullah Waheed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #867