Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(deps): update dependency @edx/frontend-platform to v5.3.0" #870

Merged

Conversation

abdullahwaheed
Copy link
Contributor

Reverts #867

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (db0f8f8) 46.54% compared to head (34e5811) 46.54%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #870   +/-   ##
=======================================
  Coverage   46.54%   46.54%           
=======================================
  Files         122      122           
  Lines        2548     2548           
  Branches      669      669           
=======================================
  Hits         1186     1186           
  Misses       1286     1286           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abdullahwaheed abdullahwaheed merged commit a2b2544 into master Sep 5, 2023
8 checks passed
@abdullahwaheed abdullahwaheed deleted the revert-867-renovate/edx-frontend-platform-5.x branch September 5, 2023 15:24
@arbrandes
Copy link
Contributor

@Syed-Ali-Abbas-Zaidi, @abdullahwaheed, I didn't catch this locally, apologies. Let's figure out the best strategy: react-redux 8 is not supposed to be a breaking change, so if I'm reading this right we "just" have to bump the peer deps.

abdullahwaheed added a commit that referenced this pull request Sep 21, 2023
* feat: add toggling for the hardcode support link (master)

Add a toggling mechanism for the "unlink all social media
accounts" text to show it as a link or text depending on
the MFE env setting.

* fix(deps): update dependency @edx/frontend-platform to v5.3.0

* Revert "fix(deps): update dependency @edx/frontend-platform to v5.3.0" (#870)

This reverts commit 757e446.

* feat: add toggling for the hardcode support link (master)

Add a toggling mechanism for the "unlink all social media
accounts" text to show it as a link or text depending on
the MFE env setting.

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Muhammad Abdullah Waheed <42172960+abdullahwaheed@users.noreply.github.com>
snglth pushed a commit to Abstract-Tech/community-theme-account that referenced this pull request Jan 9, 2024
…x#864)

* feat: add toggling for the hardcode support link (master)

Add a toggling mechanism for the "unlink all social media
accounts" text to show it as a link or text depending on
the MFE env setting.

* fix(deps): update dependency @edx/frontend-platform to v5.3.0

* Revert "fix(deps): update dependency @edx/frontend-platform to v5.3.0" (openedx#870)

This reverts commit 757e446.

* feat: add toggling for the hardcode support link (master)

Add a toggling mechanism for the "unlink all social media
accounts" text to show it as a link or text depending on
the MFE env setting.

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Muhammad Abdullah Waheed <42172960+abdullahwaheed@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants