Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added link to documentation on preferences UI #869

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

sundasnoreen12
Copy link
Contributor

INF-1016

Description
As per requirement from the privacy team, we added the following text on the preferences page, as shown in this mockup: https://www.figma.com/file/1WsIDaf9Alfy2r8eNYj6vX/Notifications?type=design&node-id=594-15747&mode=design&t=nMhhVBzBChGFELzX-4 .

“Notifications for certain activities are enabled by default, as detailed here.”

Screenshot
Screenshot 2023-09-05 at 1 49 11 PM

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (db0f8f8) 46.54% compared to head (ee876b5) 46.54%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #869   +/-   ##
=======================================
  Coverage   46.54%   46.54%           
=======================================
  Files         122      122           
  Lines        2548     2548           
  Branches      669      669           
=======================================
  Hits         1186     1186           
  Misses       1286     1286           
  Partials       76       76           
Files Changed Coverage Δ
...tification-preferences/NotificationPreferences.jsx 95.83% <ø> (ø)
src/notification-preferences/messages.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awais-ansari awais-ansari merged commit 869e083 into master Sep 6, 2023
8 checks passed
@awais-ansari awais-ansari deleted the sundas/INF-1016 branch September 6, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants