refactor: added paragon class

openedx · Sep 5, 2023 · ee876b5 · ee876b5
1 parent 1621825
commit ee876b5
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 13 deletions.
diff --git a/src/index.scss b/src/index.scss
@@ -78,10 +78,12 @@ $fa-font-path: "~font-awesome/fonts";
   line-height: 28px;
 }
 
-.notification-launch-icon {
-  vertical-align: middle;
-  height: 16px;
-  width: 16px;
+.text-decoration-underline {
+  text-decoration: underline;
+}
+
+.pgn__hyperlink__external-icon{
+  margin-left: 4px;
 }
 
 .notification-preferences {

diff --git a/src/notification-preferences/NotificationPreferences.jsx b/src/notification-preferences/NotificationPreferences.jsx
@@ -2,8 +2,10 @@ import React, { useEffect, useMemo } from 'react';
 import { useDispatch, useSelector } from 'react-redux';
 import { Link, useParams } from 'react-router-dom';
 import { useIntl } from '@edx/frontend-platform/i18n';
-import { Container, Icon, Spinner } from '@edx/paragon';
-import { ArrowBack, Launch } from '@edx/paragon/icons';
+import {
+  Container, Icon, Spinner, Hyperlink,
+} from '@edx/paragon';
+import { ArrowBack } from '@edx/paragon/icons';
 import {
   selectCourseListStatus,
   selectCourse,
@@ -60,15 +62,15 @@ const NotificationPreferences = () => {
         {intl.formatMessage(messages.notificationHeading)}
       </h2>
       <div className="mb-6 text-gray-700">
-        Notifications for certain activities are enabled by default, {' '}
-        <a
-          className="w-100"
+        {intl.formatMessage(messages.notificationPreferenceGuideBody)}
+        <Hyperlink
+          destination="https://edx.readthedocs.io/projects/open-edx-learner-guide/en/latest/sfd_notifications/managing_notifications.html"
           target="_blank"
-          href="https://edx.readthedocs.io/projects/open-edx-learner-guide/en/latest/sfd_notifications/managing_notifications.html"
-          rel="noreferrer"
+          rel="noopener noreferrer"
+          className="text-decoration-underline"
         >
-          as detailed here <Icon className="d-inline-block notification-launch-icon" src={Launch} />
-        </a>
+          {intl.formatMessage(messages.notificationPreferenceGuideLink)}
+        </Hyperlink>
       </div>
       <div className="h-100">
         <div className="d-flex mb-5">

diff --git a/src/notification-preferences/messages.js b/src/notification-preferences/messages.js
@@ -53,4 +53,14 @@ export const messages = defineMessages({
     defaultMessage: 'Load more courses',
     description: 'Load more button to load more courses',
   },
+  notificationPreferenceGuideLink: {
+    id: 'notification.preference.guide.link',
+    defaultMessage: 'as detailed here',
+    description: 'Link of the notification preference for learner guide',
+  },
+  notificationPreferenceGuideBody: {
+    id: 'notification.preference.guide.body',
+    defaultMessage: 'Notifications for certain activities are enabled by default, ',
+    description: 'Body of the notification preferences for learner guide',
+  },
 });