-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show exception message from filters in the user interface #35407
base: master
Are you sure you want to change the base?
feat: show exception message from filters in the user interface #35407
Conversation
Thanks for the pull request, @felipemontoya! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@@ -422,6 +423,8 @@ def change_enrollment(request, check_access=True): | |||
enroll_mode = CourseMode.auto_enroll_mode(course_id, available_modes) | |||
if enroll_mode: | |||
CourseEnrollment.enroll(user, course_id, check_access=check_access, mode=enroll_mode) | |||
except EnrollmentNotAllowed as exec: # pylint: disable=broad-except |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would the pylint disable be needed in this case?
Hi @felipemontoya and @mariajgrimaldi! Just checking in to see if this pull request is still in progress? |
Friendly ping on this, @felipemontoya! |
@mphilbrick211: I can take this. Once I've fixed the quality issues, I'll ask for a review again. In the meantime, I'll convert this into a draft. |
8f096f9
to
f1a84a5
Compare
Hey, @MaferMazu, can you help us with a review? Thanks! |
Description
This PR connects the output from the
org.openedx.learning.course.enrollment.started.v1
orCourseEnrollmentStarted
into the API that responds to the user action in the UI.Useful information to include:
Testing instructions
In tutor:
your_package.pipeline
with this code:Deadline
Ideally soon, but there is no great rush as this has been present for a while.