Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show exception message from filters in the user interface #35407

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

felipemontoya
Copy link
Member

Description

This PR connects the output from the org.openedx.learning.course.enrollment.started.v1 or CourseEnrollmentStarted into the API that responds to the user action in the UI.

Useful information to include:

  • This impacts developers that are using open edX filters to create their own rules for enrollment.

Testing instructions

In tutor:

  • Use a tutor environment with edx-platform with this branch
  • create a filter in your_package.pipeline with this code:
from openedx_filters import PipelineStep
from openedx_filters.learning.filters import CourseEnrollmentStarted

class MyFilterToStopEnrollment(PipelineStep):   # pylint: disable=too-few-public-methods
    """
    Stop enrollment process raising PreventEnrollment exception
    """

    def run_filter(self, user, course_key, mode):
        """Filter."""
        raise CourseEnrollmentStarted.PreventEnrollment(_("You can't enroll on this course as there is custom code preventing it"))
  • You need to add the following settings to your settings
OPEN_EDX_FILTERS_CONFIG = {
        "org.openedx.learning.course.enrollment.started.v1": {
            "fail_silently": False,
            "pipeline": [
                "your_package.pipeline.MyFilterToStopEnrollment",
            ],
        },
    }
  • Go to any course-about page in the platform and try to enroll. The message "you can't enroll on this course as there is custom code preventing it" should be visible.

Deadline

Ideally soon, but there is no great rush as this has been present for a while.

@felipemontoya felipemontoya requested a review from a team as a code owner August 30, 2024 21:58
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 30, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 30, 2024

Thanks for the pull request, @felipemontoya!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@@ -422,6 +423,8 @@ def change_enrollment(request, check_access=True):
enroll_mode = CourseMode.auto_enroll_mode(course_id, available_modes)
if enroll_mode:
CourseEnrollment.enroll(user, course_id, check_access=check_access, mode=enroll_mode)
except EnrollmentNotAllowed as exec: # pylint: disable=broad-except
Copy link
Member

@mariajgrimaldi mariajgrimaldi Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would the pylint disable be needed in this case?

@mphilbrick211
Copy link

Hi @felipemontoya and @mariajgrimaldi! Just checking in to see if this pull request is still in progress?

@mphilbrick211
Copy link

Hi @felipemontoya and @mariajgrimaldi! Just checking in to see if this pull request is still in progress?

Friendly ping on this, @felipemontoya!

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Dec 10, 2024

@mphilbrick211: I can take this. Once I've fixed the quality issues, I'll ask for a review again. In the meantime, I'll convert this into a draft.

@mariajgrimaldi mariajgrimaldi marked this pull request as draft December 10, 2024 22:07
@mariajgrimaldi mariajgrimaldi dismissed their stale review December 10, 2024 22:08

I'm taking this over.

@mariajgrimaldi mariajgrimaldi force-pushed the fmo/enrollment_api_filter_message branch from 8f096f9 to f1a84a5 Compare December 10, 2024 22:30
@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review December 10, 2024 22:58
@mariajgrimaldi
Copy link
Member

Hey, @MaferMazu, can you help us with a review? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

4 participants