Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: problem editor content style #34869

Open
wants to merge 1 commit into
base: open-release/redwood.master
Choose a base branch
from

Conversation

ihor-romaniuk
Copy link
Contributor

@ihor-romaniuk ihor-romaniuk commented May 29, 2024

Description

This pull request contains styling fixes of content editor for Problem xblock. For fields Question, Answers, Feedback, Hints:

  • [1] Heading 3, Heading 4, Heading 5, Heading 6
  • [2] Numbered list is displayed without numbers

Related Pull Requests

PR to the quince branch: #34870
PR to the master branch: openedx/frontend-lib-content-components#478

Screenshots before:

[1] image [1] image [2] image [2] image

Screenshots after:

[1] image [1] image [2] image [2] image

Steps to Reproduce:

  1. Enable new problem editor and sharing by adding in /admin/waffle/flag/
  1. In studio open unit -> add new component -> Problem -> Single / Multiple select
  2. Check problem displaying

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 29, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added backport PR backports a change from main to a named release. needs reviewer assigned PR needs to be (re-)assigned a new reviewer labels May 31, 2024
@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/fix/fix-text-editor-text-style-redwood branch from d456f78 to 521f798 Compare June 3, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. needs reviewer assigned PR needs to be (re-)assigned a new reviewer open-source-contribution PR author is not from Axim or 2U
Projects
Status: Backlog
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants