Fix: Course team members are included in "Learners in the track" emails recipients #34609
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @DmytroAlipov! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
DmytroAlipov
force-pushed
the
selection-of-users-for-sending-email
branch
8 times, most recently
from
28455f7 to
0b6d774
Compare
mphilbrick211
added
the
needs reviewer assigned
DmytroAlipov
force-pushed
the
selection-of-users-for-sending-email
branch
from
0b6d774 to
cf20f90
Compare
|
@mphilbrick211 friendly ping |
Hi @DmytroAlipov! We have this out to the community for review. Thank you for your patience. |
|
@mphilbrick211 I can take the review on this. |
| result = target.get_users(self.course.id) | ||
|
|
||
| assert result.count() == 1 | ||
| assert result.filter(id=self.user2.id).exists() |
There was a problem hiding this comment.
can we also check if staff_user does not exist here?
There was a problem hiding this comment.
@DmytroAlipov there are a few comments but overall it looks good, once you address them we can merge.
DmytroAlipov
force-pushed
the
selection-of-users-for-sending-email
branch
2 times, most recently
from
4bede1c to
94b4056
Compare
|
@farhaanbukhsh done |
mphilbrick211
removed
the
needs reviewer assigned
There was a problem hiding this comment.
👍
- ✅ I tested this on Tutor and queries worked
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
- ❌ I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
farhaanbukhsh
force-pushed
the
selection-of-users-for-sending-email
branch
from
94b4056 to
4a9f32b
Compare
Course team members are included in "Learners in the track" emails recipients.
DmytroAlipov
force-pushed
the
selection-of-users-for-sending-email
branch
from
4a9f32b to
0868c44
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
This applies to bulk emails.
To reproduce the problem follow these steps:
Expected Result
Probably course team users should be excluded from those emails to "Learners in the corresponding track" same as they are excluded from emails sent to All learners.
https://edx.readthedocs.io/projects/open-edx-building-and-running-a-course/en/latest/manage_live_course/bulk_email.html#who-is-included-in-each-recipient-group