Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: course progress url based on whether the user has learning MFE enabled (for Quince) #34343

Conversation

FatemeKhodayari
Copy link
Contributor

Currently, as we have in Quince, when a user hasn't passed the course, the "View Grades" link / button is displayed to him on the dashboard. Clicking on this link / button, takes the user to the old progress page. The URL of the old progress page is returned in the /api/learner_home/init response. In this change, course progress URL is returned based on whether the user has learning MFE enabled or not.

This issue was originally created in this forum topic and later discussed a little bit in the Maintenance WG meeting.

Closes #34323

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 9, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @FatemeKhodayari! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 11, 2024
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 14, 2024
@mphilbrick211
Copy link

Hi @FatemeKhodayari! Just flagging there is a failing test. Would you mind taking a look?

@FatemeKhodayari
Copy link
Contributor Author

Hi @FatemeKhodayari! Just flagging there is a failing test. Would you mind taking a look?

Hi @mphilbrick211. Actually I'm waiting for @feanil's response to my comment in the master PR as the change causing the failure is because of the suggested solution and I'm not sure what's the best way for fixing the lint import error.

If you or any body else knows how this error must be fixed, I'd appreciate the help.

@feanil feanil self-requested a review March 19, 2024 19:14
@FatemeKhodayari FatemeKhodayari force-pushed the fix/progress-page-url branch 2 times, most recently from 81e64f7 to 0a8c4ba Compare March 31, 2024 02:02
@FatemeKhodayari FatemeKhodayari force-pushed the fix/progress-page-url branch from 8fbe55c to 1665f8f Compare June 28, 2024 12:39
@feanil
Copy link
Contributor

feanil commented Jul 16, 2024

@FatemeKhodayari thanks for the contribution! Any chance you can make the same fix to the redwood branch as well?

@feanil feanil merged commit 6d2c0e6 into openedx:open-release/quince.master Jul 16, 2024
43 checks passed
@openedx-webhooks
Copy link

@FatemeKhodayari 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@FatemeKhodayari
Copy link
Contributor Author

FatemeKhodayari commented Jul 18, 2024

@FatemeKhodayari thanks for the contribution! Any chance you can make the same fix to the redwood branch as well?

Sure. I'll try to get it done by the end of the week. Also thank you for all the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants