feat: send course role events to the event bus #34158
Conversation
zacharis278
force-pushed
the
zhancock/access-role-events
branch
from
74bf041 to
29eb740
Compare
| Emit an event to the event-bus when a CourseAccessRole is created | ||
| """ | ||
| user = instance.user | ||
| # do we want to guard against updating an existing role instance in place |
There was a problem hiding this comment.
torn here, leaving this as is make everything a lot more simple but leaves a gap if down the line we were to write code that took an existing CourseAccessRole instance and changed the role on it rather than creating a new instance for a different role.
The only option is do some pre_save code to keep track of the former value or do this in the save() method on the model without signals. I'm leaning towards the latter.
There was a problem hiding this comment.
Do we anticipate changes being made to the CourseAccessRole soon? If not, I feel like the gap is fine. If this area were in active development, then we would probably be better off closing that gap like you suggested.
I am curious is any future work with roles and permissions could affect this 🤔
If the gap is too much of a risk (which it very well could be, given the discovery work already happening with roles and permissions), I agree that doing this in the save() method would be a good solution.
There was a problem hiding this comment.
soon no, and long term this will be removed and replaced with an event for a granted permission instead. I tried using the save() method but it still adds some complexity keeping track of the former value so I'm just going to keep this short version for now.
zacharis278
force-pushed
the
zhancock/access-role-events
branch
from
29eb740 to
d695466
Compare
zacharis278
force-pushed
the
zhancock/access-role-events
branch
from
2affb8a to
f719ecc
Compare
zacharis278
force-pushed
the
zhancock/access-role-events
branch
5 times, most recently
from
cdf841f to
b2fbbc2
Compare
zacharis278
force-pushed
the
zhancock/access-role-events
branch
from
b2fbbc2 to
b11a21f
Compare
zacharis278
force-pushed
the
zhancock/access-role-events
branch
from
5f1126a to
3b4d6c7
Compare
zacharis278
force-pushed
the
zhancock/access-role-events
branch
from
3b4d6c7 to
7891e2c
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Notify the event bus when a user's role in a course is added or removed. These will eventually be consumed by edx-exams to sync access instructor endpoints.
event definitions: openedx/openedx-events#309
2u-internal ticket: COSMO-156